Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the jupyiter notebook links in example workflows section #1160

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

jpurusho65
Copy link
Contributor

Describe your changes and why you are making these changes

Update the jupyiter notebook links in example workflows section

Related issue number (if any)

ENG-2721

Loom demo (if any)

Checklist before requesting a review

  • [ x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@jpurusho65 jpurusho65 self-assigned this Mar 31, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jpurusho65 jpurusho65 requested a review from vsreekanti March 31, 2023 23:16
@vsreekanti
Copy link
Contributor

Yep, this is perfect — thanks @jpurusho65!

@jpurusho65 jpurusho65 added run_integration_test Triggers integration tests skip_integration_test Skips required integration test (only documentation/UI changes) and removed run_integration_test Triggers integration tests skip_integration_test Skips required integration test (only documentation/UI changes) labels Apr 1, 2023
@jpurusho65 jpurusho65 merged commit 38677ff into main Apr 3, 2023
@jpurusho65 jpurusho65 deleted the eng-2721-fix-notebook-links-in-example-workflows branch April 3, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants