Eng 2724 enable usage tracking for code spaces #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likawind
commented
Mar 30, 2023
| // This call generates a unique hash of the host device in a privacy-preserving fashion. | ||
| // Details can be found here: https://github.com/denisbrodbeck/machineid | ||
| var err error | ||
| machineID, err = machineid.ProtectedID(hashKey) |
There was a problem hiding this comment.
@cw75 For non-codespace testing, I should be able to hit this line if I run aqueduct clear followed by aqueduct start right?
There was a problem hiding this comment.
If that's the case, my local testing looks good. I also ran an instance inside code space, so as long as you can see likawind ID in our usage stats (in code_space env), we should be good to go
cw75
approved these changes
Mar 31, 2023
| // This call generates a unique hash of the host device in a privacy-preserving fashion. | ||
| // Details can be found here: https://github.com/denisbrodbeck/machineid | ||
| var err error | ||
| machineID, err = machineid.ProtectedID(hashKey) |
likawind
added
the
skip_integration_test
…g-2724-enable-usage-tracking-for-code-spaces
likawind
added
run_integration_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR enables usage tracking for codespaces by checking codespace specific env vars. We also added some documentation improvements to various observed issues when using code spaces.
Related issue number (if any)
ENG-2724
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)