-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG 2154 Add parameter information to save operator #1137
ENG 2154 Add parameter information to save operator #1137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments but you can merge once you resolve.
@eunice-chan, not sure if you've marked this as a draft because it's not ready for feedback yet. If so, feel free to disregard and share an update once you're ready. Otherwise, here's a few small design tweaks:
Good work! |
Hey Eunice, sorry if my first message wasn't clear. My suggestion was not to layout the parameters horizontally but instead to put the Inputs section of the view horizontally next to the Parameters section of the view. The original layout of the parameters was better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job getting all components modularized for reusability! My main feedback is that we already have a component
directory and it's not very clear what goes to pages/components
and what does not. I'd suggest moving InfoTooltip
to primitive
and other 3 files to workflow/operator
.
@eunice-chan, I merged #1121 just now, so you should be able to reuse the |
@likawind |
@eunice-chan sorry for the late reply. But yes, I agree with what you suggested by moving the two |
…dd-information-about-the-saved-object
Just a friendly reminder to add the |
Describe your changes and why you are making these changes
In the UI, when I click on a save operator, there is nothing in the sidesheet that is helpful for discovering where the operator is: e.g. where in the integration it is saved (table_name, path, etc).
This PR adds parameter information. Combined with #1121, which will add the integration information, will provide all necessary information.
Related issue number (if any)
ENG 2154
Loom demo (if any)
Tested with save-to-S3; save-to-SQLite (relational DB)
UPDATE 3/27 11:27AM:
S3:
RelationalDB:
RelationalDB Tooltip:
UPDATE 3/31 8:44AM:
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)