Fix build error for parcel/css on m1 mac. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agiron123 how exactly is this change fixing the issue? |
@cw75 I googled the error message and found this thread: Adding the @parcel/css package to package.json and removing package-lock.json and re-installing node_modules seemed to do the trick. My hunch is that whoever last pushed to main didn't test on an M1 mac and used an Ubuntu box instead. In the future, we should add M1 as a build target to CI/CD to ensure that our builds work for dev machines. |
vsreekanti
approved these changes
Jun 16, 2022
…utomatic Typescript typedef file generation from project.
kenxu95
pushed a commit
that referenced
this pull request
Jun 21, 2022
* Fix build error for parcel/css on m1 mac. * Sets declarations and declarationMaps to true in tsconfig to enable automatic Typescript typedef file generation from project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://linear.app/aqueducthq/issue/ENG-1248/bug-npm-run-start-fails-on-m1-mac