Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize log message in UpdateOnFailure() #1078

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

Fanjia-Yan
Copy link
Contributor

Describe your changes and why you are making these changes

Now UpdateOnFailure() takes integrationType as an extra parameter so it can customize the log message
`## Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@Fanjia-Yan Fanjia-Yan marked this pull request as ready for review March 11, 2023 01:21
@Fanjia-Yan Fanjia-Yan requested a review from cw75 March 11, 2023 01:22
@Fanjia-Yan Fanjia-Yan added the run_integration_test Triggers integration tests label Mar 13, 2023
@Fanjia-Yan Fanjia-Yan merged commit 37f7b5b into main Mar 31, 2023
@vsreekanti vsreekanti deleted the eng-2590-incorrect-log-message-in branch April 4, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants