Skip to content

panda + tiger + eagle without complete test #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

panda + tiger + eagle without complete test #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdfb03d
shows QH instead of queen-hearts
lww Mar 9, 2013
49bc5e6
add stand for player if he busts and update test
lww Mar 9, 2013
b3e30f0
adds dealer hand does not show both cards until player stands
lww Mar 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions blackjack.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def value
end

def to_s
"#{@value}-#{suit}"
"#{@value}#{suit.to_s.chars.first.upcase}"
end

end
Expand Down Expand Up @@ -75,15 +75,28 @@ def initialize

def hit
@player_hand.hit!(@deck)
if @player_hand.value > 21
puts "Player busted!"
stand
end_status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than two methods, one names "end_status" and one named "pre_status", I think you should have 1 method "status" that returns different data based on its game state

else
pre_status
end
end

def stand
@dealer_hand.play_as_dealer(@deck)
@winner = determine_winner(@player_hand.value, @dealer_hand.value)
end

def status
{:player_cards=> @player_hand.cards,
def pre_status
{ :player_cards => @player_hand.cards,
:player_value => @player_hand.value,
:dealer_cards => @dealer_hand.cards[0] }
end

def end_status
{:player_cards => @player_hand.cards,
:player_value => @player_hand.value,
:dealer_cards => @dealer_hand.cards,
:dealer_value => @dealer_hand.value,
Expand All @@ -103,7 +116,7 @@ def determine_winner(player_value, dealer_value)
end

def inspect
status
pre_status
end
end

Expand Down Expand Up @@ -135,7 +148,7 @@ def inspect

it "should be formatted nicely" do
card = Card.new(:diamonds, "A")
card.to_s.should eq("A-diamonds")
card.to_s.should eq("AD")
end
end

Expand Down