Parse currency correctly if found from existing hash

[kahshing96]

• Fix parsing issue for certain currency symbols like Malaysia Ringgit (RM) as addressed in Version 1.11.0 broke parsing for Malaysian ringgit when using the symbol 'RM' #153 by checking that
  • the computed_currency parsed from the given input from a match ISO currency code regex is a correct ISO code from existing Monetize::Parser::CURRENCY_SYMBOLS, then only assigned it with value
  • else fallback to use compute_currency which match against currency symbol regex
  • eg:

  "RM100".to_money    # #<Money fractional:10000 currency:MYR>
  "S$100".to_money    # #<Money fractional:10000 currency:SGD>
  "NT$100".to_money   # #<Money fractional:10000 currency:TWD>
  "HK$100".to_money   # #<Money fractional:10000 currency:HKD>
  "$100 CAD".to_money # #<Money fractional:10000 currency:CAD>

• Add & fix related rspecs

[kahshing96]

Hi @semmons99 , would you able to take a look at this PR?

[semmons99]

ty. merged!

[kahshing96]

Hi @semmons99 thanks for merging, is it possible to bump the version for this gem in both rubygems and create a new version tag in Github ?

[semmons99]

done. release 1.13.0 @kahshing96

[Calyhre]

@kahshing96 @semmons99 That's a massive breaking change considering the limited set of CURRENCY_SYMBOLS.

# monetize 0.12.0
'100 NOK'.to_money => #<Money fractional:10000 currency:NOK>

# monetize 0.13.0 (with EUR as default)
'100 NOK'.to_money => #<Money fractional:10000 currency:EUR>

[tagliala]

Just noticed this change when writing 1.13.0 changelog

Yes, this is a breaking change and should not belong to 1.x, however, I'm wondering why this is not using ISO codes from Money (Money::Currency.all.map(&:iso_code))

[weizheheng]

Yes, this is breaking our production because Monetize::Parser::CURRENCY_SYMBOLS do not have the full list of currency. Now when we try to do:

fee = "AUD 10.00"

# Our default currency is "USD"
Monetize.parse(fee)
# => #<Money fractional:1000 currency:USD>

# The result is in USD instead of AUD