Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3944: update CSS class for DF simple text input fields on Ajax… #4030

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

MichaelThumes
Copy link
Contributor

… Update

closes issue #3944

@stefanhaerter
Copy link
Contributor

Thank you for investigating this - I am quite surprised that oooFull seems to be only handled by JavaScript and does not show up anywhere in the templates. Happy to have learned something new ^^

@svenoe
Copy link
Contributor

svenoe commented Jan 9, 2025

I think the wrong issue is referenced, here (Edit: ah - in the commit 3994, not in the message 3944). I wanted to have a look, because back in my mind, I though we had an issue where something like $Elemnt.trigger('blur') was necessary, to trigger something like setting "oooFull". Maybe either way is fine, please quickly consider, whether there might be something missing for other field types, whether oooFull is only set on the parent and not also somewhere on the label or so (just not sure, right now), and probably, if you decide to keep the manual setting of oooFull (which might just be fine), still move it down a bit, at least to after the reference fields, where the element might be of type text, too (also not 100% sure, but definitely text inputs are used in other field types, too - maybe not as the main input which is $Element).

@MichaelThumes
Copy link
Contributor Author

alternative solution, which seems to have same effect of adding 'oooFull' css class to parent Element:

at the very end of UpdateFormElements() in Core.AJAX.js:

diff --git a/var/httpd/htdocs/js/Core.AJAX.js b/var/httpd/htdocs/js/Core.AJAX.js
index 942080351..42b10dd5c 100644
--- a/var/httpd/htdocs/js/Core.AJAX.js
+++ b/var/httpd/htdocs/js/Core.AJAX.js
@@ -478,14 +478,16 @@ Core.AJAX = (function (TargetNS) {
             // Other form elements
             $Element.val(DataValue);
 
             // Trigger custom redraw event for InputFields
             if ($Element.hasClass('Modernize')) {
                 $Element.trigger('redraw.InputField');
             }
+            
+            $Element.trigger('blur');
         });
     }

Hm, maybe this is actually even less invasive?

@svenoe let me know if your prefer this way, I would then update the branch accordingly?

@svenoe svenoe merged commit d830324 into rel-11_0 Jan 14, 2025
1 check passed
@svenoe svenoe deleted the issue-#3944-DF-label-customerInterface branch January 14, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants