Short circuits

[Saelyos]

• Add short circuit calculation
• Remove absolufy-imports

[benoit9126]

Great for pre-commit. I will propagate this configuration to our other libraries.

I would also add some features in this PR:

• The possibility to remove a short-circuit (or maybe to clear them)
• The ability to have a data frame of shorts circuits in the ElectricalNetwork instance
• How do you handle short-circuits between the three phases?
• [Disclaimer: potential Newby question] Why is the neutral excluded?

[Saelyos]

@benoit9126

• Removing a short-circuit is not something we can have in the engine part, but we can do it here if we want (it will be overridden in engine to raise an exception).
• I'll add that
• I've just added it (we have discussed about it with @alihamdan for the interface)
• I'm not sure what you're referring to, I've added a test with only "abc" phases, but otherwise "n" is allowed

[alihamdan]

Left you some comments

[benoit9126]

I would have added a sorted in order to have "abcn" rather than "nbca": "".join(sorted(bus._short_circuit))

[benoit9126]

@Saelyos Great! Forget what I wrote about the neutral. I read your code too quickly

[benoit9126]

@Saelyos Do not forget to add documentation on short circuits.

[benoit9126]

@Saelyos A few additional questions/remarks:

• Could you please add some examples showing that the library protects the user from inconsistent behaviour (in the notebook) ? Example: adding a PowerLoad in a bus with a short circuit, etc.
• Currently, it is impossible to model two short circuits in the same bus. Example: I have a ABCN bus and I would like to model a short circuit between the phase A and B and another between the phases C and N. ⇾ It should not be common to do such things, I suppose.