Conversation
benoit9126
requested changes
Nov 17, 2023
Member
benoit9126
left a comment
benoit9126
left a comment
There was a problem hiding this comment.
Great! Please add a line in the changelog and maybe some documentation related to the possibility to give a quantity of array or an array of quantities (maybe with different units such as v=[Q_(400, "V"), Q_(0.4, "kV"), 400])
alihamdan
requested changes
Nov 17, 2023
Member
alihamdan
left a comment
alihamdan
left a comment
There was a problem hiding this comment.
This looks very good, thank you.
I just think it is better if this module was private: _wrapper.py. In the future we might delete it if pint evolves to have these improvements built in and we don't want anyone depending on it.
I also left two comments about additional tiny performance improvements, feel free to include.
alihamdan
approved these changes
Nov 17, 2023
benoit9126
approved these changes
Nov 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strictis always False, no named values)