Add some shortcuts to the Line class#128
Merged
benoit9126 merged 2 commits intodevelopfrom Sep 6, 2023
Merged
Conversation
alihamdan
approved these changes
Sep 6, 2023
Member
alihamdan
left a comment
alihamdan
left a comment
There was a problem hiding this comment.
Nice.
Maybe mention them in the docs? Also please add a changelog entry.
Member
Author
|
Sure. I wanted to be sure of the name of the methods before |
Saelyos
approved these changes
Sep 6, 2023
benoit9126
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal of @YassineAbdelouadoud who wanted to have access to the impedance and shunt admittance of the line from a Line instance directly (in Ohm and in S). To avoid confusion between ohm/km (resp. S/km) and ohm (resp. ohm/km), the name of the methods should maybe be changed...