Skip to content

Update non-euclidean projections#106

Merged
Saelyos merged 2 commits intodevelopfrom
projections
Jul 31, 2023
Merged

Update non-euclidean projections#106
Saelyos merged 2 commits intodevelopfrom
projections

Conversation

@Saelyos
Copy link
Collaborator

@Saelyos Saelyos commented Jul 31, 2023 •
edited
Loading

  • The keep_p and keep_q projections have been reworked in the engine part to accept higher alpha values. Now the DEFAULT_ALPHA=1000 is fine.
  • The default epsilon has been decreased to 1e-8

@Saelyos Saelyos requested a review from alihamdan July 31, 2023 10:05
@Saelyos Saelyos merged commit 8ad660b into develop Jul 31, 2023
@Saelyos Saelyos deleted the projections branch July 31, 2023 10:19
@Saelyos Saelyos self-assigned this Jul 31, 2023
@Saelyos Saelyos added the enhancement New feature or request label Jul 31, 2023
@benoit9126 benoit9126 mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alihamdan alihamdan alihamdan approved these changes

Assignees

@Saelyos Saelyos

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Saelyos @alihamdan