This repository was archived by the owner on May 15, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(gemini): add minimal and medium reasoning effort levels #9973
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f04433d
feat(gemini): add minimal and medium reasoning effort levels
hannesrudolph 5772e89
refactor: derive GeminiThinkingLevel type from const array
roomote 9838370
Add changeset
cte 173814d
refactor(gemini): add isGeminiThinkingLevel type guard function
roomote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,10 @@ export type AnthropicReasoningParams = BetaThinkingConfigParam | |
|
|
||
| export type OpenAiReasoningParams = { reasoning_effort: OpenAI.Chat.ChatCompletionCreateParams["reasoning_effort"] } | ||
|
|
||
| export type GeminiThinkingLevel = "minimal" | "low" | "medium" | "high" | ||
|
|
||
| export type GeminiReasoningParams = GenerateContentConfig["thinkingConfig"] & { | ||
| thinkingLevel?: "low" | "high" | ||
| thinkingLevel?: GeminiThinkingLevel | ||
| } | ||
|
|
||
| export type GetModelReasoningOptions = { | ||
|
|
@@ -116,6 +118,9 @@ export const getOpenAiReasoning = ({ | |
| } | ||
| } | ||
|
|
||
| // Valid Gemini thinking levels for effort-based reasoning | ||
| const GEMINI_THINKING_LEVELS: readonly GeminiThinkingLevel[] = ["minimal", "low", "medium", "high"] as const | ||
|
|
||
| export const getGeminiReasoning = ({ | ||
| model, | ||
| reasoningBudget, | ||
|
|
@@ -136,15 +141,15 @@ export const getGeminiReasoning = ({ | |
| | "disable" | ||
| | undefined | ||
|
|
||
| // Respect “off” / unset semantics from the effort selector itself. | ||
| // Respect "off" / unset semantics from the effort selector itself. | ||
| if (!selectedEffort || selectedEffort === "disable") { | ||
| return undefined | ||
| } | ||
|
|
||
| // Effort-based models on Google GenAI currently support only explicit low/high levels. | ||
| if (selectedEffort !== "low" && selectedEffort !== "high") { | ||
| // Effort-based models on Google GenAI support minimal/low/medium/high levels. | ||
| if (!GEMINI_THINKING_LEVELS.includes(selectedEffort as GeminiThinkingLevel)) { | ||
| return undefined | ||
| } | ||
|
Comment on lines
+153
to
156
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @roomote Let's make this a proper type guard function called There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Added |
||
|
|
||
| return { thinkingLevel: selectedEffort, includeThoughts: true } | ||
| return { thinkingLevel: selectedEffort as GeminiThinkingLevel, includeThoughts: true } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more traditional way to do this is to define the array of values
as constand then derive the type from the array.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roomote Please fix this.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the reported issue. Now defines
GEMINI_THINKING_LEVELSarrayas constfirst, then derivesGeminiThinkingLeveltype from it. All local checks passed.View commit | Revert commit