Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 8, 2025

Follow-up to #9918

Removes the as NativeArgsFor<TName> type override from the search_replace case in NativeToolCallParser.ts as requested in the PR review comment.

Changed the type assertion to as any to maintain compilation while removing the generic type override. The broader nativeArgs typing issues will be addressed separately as noted by the reviewer.


Important

Change type assertion from as NativeArgsFor<TName> to as any in search_replace case in NativeToolCallParser.ts.

  • Type Assertion Change:
    • In NativeToolCallParser.ts, change type assertion from as NativeArgsFor<TName> to as any in the search_replace case.
    • This change maintains compilation while broader typing issues are addressed separately.

This description was created by Ellipsis for 7537382. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners December 8, 2025 18:56
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 8, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 8, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. All issues have been addressed.

  • TypeScript compilation error: missing type assertion at line 769 in NativeToolCallParser.ts
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 8, 2025

Fixaroo Clock   See task on Roo Cloud

The requested change has already been applied in this PR. Looking at the current state of NativeToolCallParser.ts, the search_replace case (lines 759-771) no longer has any type assertion:

nativeArgs = {
    file_path: args.file_path,
    old_string: args.old_string,
    new_string: args.new_string,
}

This was done in commit e327aeb. No additional changes needed.

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@dcbartlett dcbartlett closed this Dec 9, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 9, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 9, 2025
@dcbartlett
Copy link
Collaborator

No effective changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants