-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: remove NativeArgsFor<TName> type override from search_replace case #9922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review complete. All issues have been addressed.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
The requested change has already been applied in this PR. Looking at the current state of nativeArgs = {
file_path: args.file_path,
old_string: args.old_string,
new_string: args.new_string,
}This was done in commit e327aeb. No additional changes needed. |
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
|
No effective changes |
Follow-up to #9918
Removes the
as NativeArgsFor<TName>type override from thesearch_replacecase in NativeToolCallParser.ts as requested in the PR review comment.Changed the type assertion to
as anyto maintain compilation while removing the generic type override. The broader nativeArgs typing issues will be addressed separately as noted by the reviewer.Important
Change type assertion from
as NativeArgsFor<TName>toas anyinsearch_replacecase inNativeToolCallParser.ts.NativeToolCallParser.ts, change type assertion fromas NativeArgsFor<TName>toas anyin thesearch_replacecase.This description was created by
for 7537382. You can customize this summary. It will automatically update as commits are pushed.