Skip to content

Always enabled reasoning for models that require it #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cte merged 3 commits into from
Dec 4, 2025
Merged

Always enabled reasoning for models that require it #9836

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba9a6a1
Always enabled reasoning for models that require it
cte Dec 4, 2025
ca793aa
PR feedback
cte Dec 4, 2025
1a11b99
This seems more correct
cte Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/api/transform/reasoning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,18 @@ export const getRooReasoning = ({
settings,
}: GetModelReasoningOptions): RooReasoningParams | undefined => {
// Check if model supports reasoning effort
if (!model.supportsReasoningEffort) return undefined
if (!model.supportsReasoningEffort) {
return undefined
}

if (model.requiredReasoningEffort) {
// Honor the provided effort if it's valid, otherwise let the model choose.
if (reasoningEffort && reasoningEffort !== "disable" && reasoningEffort !== "minimal") {
return { enabled: true, effort: reasoningEffort }
} else {
return { enabled: true }
}
}

// Explicit off switch from settings: always send disabled for back-compat and to
// prevent automatic reasoning when the toggle is turned off.
Expand Down
Loading