Skip to content

Update model key for minimax in MODEL_DEFAULTS #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
Dec 3, 2025
Merged

Update model key for minimax in MODEL_DEFAULTS #9778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7960e25
Update model key for minimax in MODEL_DEFAULTS
mrubens Dec 3, 2025
792a53e
fix: update test file to use minimax/minimax-m2:free model key
roomote Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/api/providers/__tests__/roo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ vitest.mock("../../providers/fetchers/modelCache", () => ({
inputPrice: 0,
outputPrice: 0,
},
"minimax/minimax-m2": {
"minimax/minimax-m2:free": {
maxTokens: 32_768,
contextWindow: 1_000_000,
supportsImages: false,
Expand Down Expand Up @@ -425,12 +425,12 @@ describe("RooHandler", () => {
}
})

it("should apply defaultToolProtocol: native for minimax/minimax-m2", () => {
it("should apply defaultToolProtocol: native for minimax/minimax-m2:free", () => {
const handlerWithMinimax = new RooHandler({
apiModelId: "minimax/minimax-m2",
apiModelId: "minimax/minimax-m2:free",
})
const modelInfo = handlerWithMinimax.getModel()
expect(modelInfo.id).toBe("minimax/minimax-m2")
expect(modelInfo.id).toBe("minimax/minimax-m2:free")
expect((modelInfo.info as any).defaultToolProtocol).toBe("native")
// Verify cached model info is preserved
expect(modelInfo.info.maxTokens).toBe(32_768)
Expand All @@ -451,7 +451,7 @@ describe("RooHandler", () => {

it("should not override existing properties when applying MODEL_DEFAULTS", () => {
const handlerWithMinimax = new RooHandler({
apiModelId: "minimax/minimax-m2",
apiModelId: "minimax/minimax-m2:free",
})
const modelInfo = handlerWithMinimax.getModel()
// The defaults should be merged, but not overwrite existing cached values
Expand Down
2 changes: 1 addition & 1 deletion src/api/providers/fetchers/roo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { DEFAULT_HEADERS } from "../constants"
// These override API-provided values for specific models
// Exported so RooHandler.getModel() can also apply these for fallback cases
export const MODEL_DEFAULTS: Record<string, Partial<ModelInfo>> = {
"minimax/minimax-m2": {
"minimax/minimax-m2:free": {
Copy link
Contributor

@roomote roomote bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break existing tests. The test file references "minimax/minimax-m2" (without :free) in the mock cache (line 105) and in test cases (lines 428-461), but this PR changes the MODEL_DEFAULTS key to "minimax/minimax-m2:free". When getModel() looks up MODEL_DEFAULTS[modelId] with modelId="minimax/minimax-m2", it won't find the entry because the key is now "minimax/minimax-m2:free", causing test assertions to fail.

Fix it with Roo Code or mention @roomote and request a fix.

Copy link
Collaborator Author

@mrubens mrubens Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roomote please fix

Copy link
Contributor

@roomote roomote bot Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixaroo Clock   See task on Roo Cloud

Fixed the reported issues. All local checks passed.

View commit | Revert commit

defaultToolProtocol: "native",
},
"anthropic/claude-haiku-4.5": {
Expand Down
Loading