Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 18, 2025

This PR attempts to address Issue #9328 where text was being lost when clicking the Resume Task button.

Problem

When users clicked the Resume Task button, any text they had typed in the input area was being cleared, causing data loss.

Solution

Modified the handlePrimaryButtonClick function in ChatView.tsx to handle the resume_task case separately:

  • Resume Task now sends the button click without clearing the input value
  • Maintains the current behavior of not sending the text with Resume Task (as requested)
  • Text in the input area is preserved when Resume Task is clicked

Changes

  • Separated resume_task case from other button clicks in handlePrimaryButtonClick
  • Removed the setInputValue("") and setSelectedImages([]) calls for the resume_task case

Testing

  • All existing tests pass
  • Manually verified that text is preserved when clicking Resume Task

Fixes #9328

Feedback and guidance are welcome!


Important

Fixes text input loss when 'Resume Task' button is clicked by modifying handlePrimaryButtonClick in ChatView.tsx.

  • Behavior:
    • Modify handlePrimaryButtonClick in ChatView.tsx to handle resume_task separately, preserving text input.
    • resume_task sends button click without clearing input, maintaining current behavior of not sending text.
  • Code Changes:
    • Separate resume_task case from other button clicks in handlePrimaryButtonClick.
    • Remove setInputValue("") and setSelectedImages([]) for resume_task case.
  • Testing:
    • All existing tests pass.
    • Manually verified text preservation on Resume Task click.

This description was created by Ellipsis for 55aecc6. You can customize this summary. It will automatically update as commits are pushed.

- Modified handlePrimaryButtonClick to handle resume_task separately
- Resume Task now sends the button click without clearing the input
- Maintains current behavior of not sending text with Resume Task
- Fixes #9328 where text was lost when clicking Resume Task
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 18, 2025 03:58
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 18, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Prompt lost when clicking “Resume Task”, text not sent and data loss

3 participants