Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 18, 2025

This PR attempts to address Issue #9328. Feedback and guidance are welcome.

Problem

When users click the "Resume Task" button with text in the prompt input, the text is cleared without being sent as feedback, causing data loss.

Solution

Modified the handlePrimaryButtonClick function in ChatView.tsx to always send text/images when the Resume Task button is clicked, ensuring user feedback is preserved and sent. This matches the behavior of Save/Reject buttons after file edits.

Changes

  • Updated the resume_task case in handlePrimaryButtonClick to always include text and images in the message payload
  • Simplified the logic to ensure feedback is never lost when resuming a task

Testing

  • All existing tests pass (976 passed, 6 skipped)
  • The fix ensures that any text typed in the prompt is sent as feedback when Resume Task is clicked

Fixes #9328


Important

Fixes issue in ChatView.tsx where "Resume Task" button cleared input without sending feedback by updating handlePrimaryButtonClick to always send text/images.

  • Behavior:
    • Fixes issue where clicking "Resume Task" button in ChatView.tsx cleared input without sending feedback.
    • handlePrimaryButtonClick now always sends text/images when "Resume Task" is clicked.
  • Testing:
    • All existing tests pass (976 passed, 6 skipped).
    • Ensures text in prompt is sent as feedback when "Resume Task" is clicked.

This description was created by Ellipsis for fd395dc. You can customize this summary. It will automatically update as commits are pushed.

- Modified handlePrimaryButtonClick to always send text/images when Resume Task is clicked
- This ensures user feedback is preserved and sent, matching the behavior of Save/Reject buttons
- Fixes #9328 where prompt was being cleared without being sent
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 18, 2025 03:19
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 18, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The changes correctly address Issue #9328 by ensuring user feedback is always sent when clicking the Resume Task button, preventing data loss.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Prompt lost when clicking “Resume Task”, text not sent and data loss

3 participants