fix: process queued messages immediately after any tool completion #9317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9315. Feedback and guidance are welcome.
Problem
Queued messages were not being reliably injected into chat conversations. They were waiting for approval-related actions instead of being processed ASAP.
Solution
Added processQueuedMessages() call to the central pushToolResult function in presentAssistantMessage.ts. This ensures queued messages are processed immediately after ANY tool completion.
Changes
Fixes #9315
Important
This PR modifies
presentAssistantMessage.tsto process queued messages immediately after tool completion, removing redundant calls from individual tool files.processQueuedMessages()inpushToolResultinpresentAssistantMessage.tsto process queued messages immediately after any tool completion.processQueuedMessages()calls fromApplyDiffTool.ts,InsertContentTool.ts,MultiApplyDiffTool.ts, andWriteToFileTool.ts.presentAssistantMessage.ts: Modified to includeprocessQueuedMessages()call.ApplyDiffTool.ts,InsertContentTool.ts,MultiApplyDiffTool.ts,WriteToFileTool.ts: Redundant calls removed.This description was created by
for bbd8f78. You can customize this summary. It will automatically update as commits are pushed.