Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 17, 2025

This PR attempts to address Issue #9315. Feedback and guidance are welcome.

Problem

Queued messages were not being reliably injected into chat conversations. They were waiting for approval-related actions instead of being processed ASAP.

Solution

Added processQueuedMessages() call to the central pushToolResult function in presentAssistantMessage.ts. This ensures queued messages are processed immediately after ANY tool completion.

Changes

  • Modified presentAssistantMessage.ts to call processQueuedMessages() in pushToolResult
  • Removed redundant calls from individual tool files

Fixes #9315


Important

This PR modifies presentAssistantMessage.ts to process queued messages immediately after tool completion, removing redundant calls from individual tool files.

  • Behavior:
    • Calls processQueuedMessages() in pushToolResult in presentAssistantMessage.ts to process queued messages immediately after any tool completion.
    • Removes redundant processQueuedMessages() calls from ApplyDiffTool.ts, InsertContentTool.ts, MultiApplyDiffTool.ts, and WriteToFileTool.ts.
  • Files:
    • presentAssistantMessage.ts: Modified to include processQueuedMessages() call.
    • ApplyDiffTool.ts, InsertContentTool.ts, MultiApplyDiffTool.ts, WriteToFileTool.ts: Redundant calls removed.

This description was created by Ellipsis for bbd8f78. You can customize this summary. It will automatically update as commits are pushed.

- Add processQueuedMessages() call to pushToolResult in presentAssistantMessage.ts
- Remove redundant processQueuedMessages() calls from individual tool files
- Ensures queued messages are injected ASAP rather than waiting for approval-related actions

Fixes #9315
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 17, 2025 16:51
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 17, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 17, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The PR successfully addresses the queued messages issue by centralizing the processQueuedMessages() call in the pushToolResult function. This ensures queued messages are processed immediately after ANY tool completion, rather than waiting for approval-related actions.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Queued messages not reliably injected into chat conversation

3 participants