-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: remove legacy Claude 2 series and embedding models from Bedrock provider #9222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…provider - Removed anthropic.claude-2-1-v1:0, anthropic.claude-2-0-v1:0, and anthropic.claude-instant-v1:0 - Removed amazon.titan-text-embeddings-v1:0 and amazon.titan-text-embeddings-v2:0 - Updated test to use Claude 3 Sonnet instead of removed Claude 2.1 model Fixes #9220
Review completed. No issues found. The merge commit correctly resolves conflicts with main while preserving the PR's original goal of removing legacy Claude 2 and Titan embedding models. New models and features from main were properly incorporated. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Review completed. No issues found. The changes correctly remove legacy models from the AWS Bedrock provider:
Test updates appropriately use Claude 3 Sonnet with correct pricing assertions. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
@roomote fix the conflicts |
Resolved merge conflicts with main. All local checks passed. |
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-8qwvnff9d-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
|
@roomote can you just close this PR and make a new one addressing the original problem of the legacy claude 2 models? Your merge resolutions were not good at all. |
Closed this PR and created a fresh PR #10501 from main that properly removes the legacy Claude 2 models. All local checks passed. |
|
Closing this PR due to merge resolution issues. A fresh PR will be created to properly address issue #9220. |
Description
This PR attempts to address Issue #9220 by removing legacy models from the AWS Bedrock provider configuration.
Changes Made
Removed Claude 2 series models that are no longer available in AWS Bedrock:
Removed Amazon Titan embedding models that shouldn't appear in model selection:
Updated test file to use instead of the removed
Testing
Related Issue
Fixes #9220
Feedback and guidance are welcome!
Important
Remove legacy Claude 2 series and Amazon Titan embedding models from Bedrock provider configuration and update tests.
bedrock.ts.bedrock.ts.bedrock-invokedModelId.spec.tsto reflect model removals.This description was created by
for 4e7ca64. You can customize this summary. It will automatically update as commits are pushed.