-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feat: support MiniMax Anthropic Provider #9196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: support MiniMax Anthropic Provider #9196
Conversation
Reviewed the latest commit (c0fc50b). The commit removed the
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| inputPrice: 0.3, | ||
| outputPrice: 1.2, | ||
| cacheWritesPrice: 0.375, | ||
| cacheReadsPrice: 0.03, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preserveReasoning property was removed from both MiniMax model definitions, but the code in Task.ts (line 2425) still checks this.api.getModel().info.preserveReasoning to determine whether to preserve reasoning in the API history. Since MiniMax models no longer have this property, reasoning will not be preserved. If reasoning preservation is still desired for MiniMax (which now uses the Anthropic format and supports thinking blocks), you should either restore preserveReasoning: true or update the Task.ts logic to handle MiniMax's reasoning differently.
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using ant_thinking and ant_redacted_thinking block types with the Anthropic API to preserve reasoning.
|
@mrubens |
Related GitHub Issue
Issue: #9017
Description
Switch the MiniMax provider from the OAI format to the Anthropic format to better support the UI and reasoning callback.
Test Procedure
I have thoroughly tested this implementation:
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
No documentation updates are required.
Additional Notes
Get in Touch
Important
Switch MiniMax provider to Anthropic format with updated API handling, UI integration, and comprehensive testing.
provider-settings.tsandminimax.ts.MiniMaxAnthropicHandlerinminimax.tsto handle API requests using Anthropic endpoints.Task.tsto integrate new thinking and redacted thinking types.MiniMax.tsxto reflect new Anthropic endpoints in dropdown options.minimax.spec.tsforMiniMaxAnthropicHandlercovering initialization, message streaming, and error handling.MiniMaxHandlertoMiniMaxAnthropicHandlerinindex.tsandproviders/index.ts.stream.tsfor Anthropic thinking.This description was created by
for 6bdea5d. You can customize this summary. It will automatically update as commits are pushed.