Skip to content

fix: prevent context condensing on settings save when provider/model unchanged #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2025
Merged

fix: prevent context condensing on settings save when provider/model unchanged #9108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b39308c
fix: prevent context condensing on settings save when provider/model …
daniel-lxs Nov 7, 2025
eabaaa6
test: fix tautological assertion in API handler rebuild test
daniel-lxs Nov 8, 2025
5a2be5b
DRY
mrubens Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
ORGANIZATION_ALLOW_ALL,
DEFAULT_MODES,
DEFAULT_CHECKPOINT_TIMEOUT_SECONDS,
getModelId,
} from "@roo-code/types"
import { TelemetryService } from "@roo-code/telemetry"
import { CloudService, BridgeOrchestrator, getRooCodeApiUrl } from "@roo-code/cloud"
Expand Down Expand Up @@ -1295,6 +1296,31 @@ export class ClineProvider

// Provider Profile Management

/**
* Updates the current task's API handler if the provider or model has changed.
* This prevents unnecessary context condensing when only non-model settings change.
* @param providerSettings The new provider settings to apply
*/
private updateTaskApiHandlerIfNeeded(providerSettings: ProviderSettings): void {
const task = this.getCurrentTask()

if (task && task.apiConfiguration) {
// Only rebuild API handler if provider or model actually changed
// to avoid triggering unnecessary context condensing
const currentProvider = task.apiConfiguration.apiProvider
const newProvider = providerSettings.apiProvider
const currentModelId = getModelId(task.apiConfiguration)
const newModelId = getModelId(providerSettings)

if (currentProvider !== newProvider || currentModelId !== newModelId) {
task.api = buildApiHandler(providerSettings)
}
} else if (task) {
// Fallback: rebuild if apiConfiguration is not available
task.api = buildApiHandler(providerSettings)
}
}

getProviderProfileEntries(): ProviderSettingsEntry[] {
return this.contextProxy.getValues().listApiConfigMeta || []
}
Expand Down Expand Up @@ -1342,11 +1368,7 @@ export class ClineProvider

// Change the provider for the current task.
// TODO: We should rename `buildApiHandler` for clarity (e.g. `getProviderClient`).
const task = this.getCurrentTask()

if (task) {
task.api = buildApiHandler(providerSettings)
}
this.updateTaskApiHandlerIfNeeded(providerSettings)
} else {
await this.updateGlobalState("listApiConfigMeta", await this.providerSettingsManager.listConfig())
}
Expand Down Expand Up @@ -1403,11 +1425,7 @@ export class ClineProvider
}

// Change the provider for the current task.
const task = this.getCurrentTask()

if (task) {
task.api = buildApiHandler(providerSettings)
}
this.updateTaskApiHandlerIfNeeded(providerSettings)

await this.postStateToWebview()

Expand Down
Loading