Skip to content

Correct tool use suggestion to improve model adherence to suggestion #8315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Correct tool use suggestion to improve model adherence to suggestion #8315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f72f61
Correct tool use suggestion to improve model adherence to suggestion
hannesrudolph Sep 25, 2025
7b5fbbd
tweak
hannesrudolph Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/tools/multiApplyDiffTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ Error: ${failPart.error}
Suggested fixes:
1. Verify the search content exactly matches the file content (including whitespace and case)
2. Check for correct indentation and line endings
3. Use <read_file> to see the current file content
3. Use the read_file tool to verify the current file content
Copy link

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Microcopy — consider formatting the tool name with backticks for readability and consistency (e.g., "the read_file tool").

4. Consider breaking complex changes into smaller diffs
5. Ensure start_line parameter matches the actual content location
${errorDetails ? `\nDetailed error information:\n${errorDetails}\n` : ""}
Expand All @@ -476,7 +476,7 @@ Unable to apply diffs to file: ${absolutePath}
Error: ${diffResult.error}

Recovery suggestions:
1. Use <read_file> to examine the current file content
1. Use the read_file tool to verify the current file content
Copy link

@roomote roomote bot Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Same note — consider "the read_file tool" for consistent formatting and readability.

2. Verify the diff format matches the expected search/replace pattern
3. Check that the search content exactly matches what's in the file
4. Consider using line numbers with start_line parameter
Expand Down
Loading