Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Sep 25, 2025

Important

Add xai/grok-4-fast and deepseek/deepseek-chat-v3.1 models to Roo provider in roo.ts.

  • Models:
    • Add xai/grok-4-fast and deepseek/deepseek-chat-v3.1 to RooModelId type in roo.ts.
    • Update rooModels in roo.ts with configurations for xai/grok-4-fast and deepseek/deepseek-chat-v3.1, including maxTokens, contextWindow, supportsImages, supportsPromptCache, inputPrice, outputPrice, and description.

This description was created by Ellipsis for d6ea973. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Sep 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2025
@mrubens mrubens merged commit b75f8dd into main Sep 25, 2025
8 of 9 checks passed
@mrubens mrubens deleted the add_free_models_to_roo_provider branch September 25, 2025 14:00
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 25, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 25, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 25, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some issues that need attention:

  • RooModelId union doesn't include the new IDs; consider deriving from the model map or extend the union.
  • Grok 4 Fast description says "multimodal" while supportsImages is false; either enable images or adjust wording.
  • DeepSeek description mentions 128K but contextWindow is 163,840; align wording (~160K).

description:
"A versatile agentic coding stealth model that supports image inputs, accessible for free through Roo Code Cloud for a limited time. (Note: the free prompts and completions are logged by the model provider and used to improve the model.)",
},
"xai/grok-4-fast": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: New model IDs were added but RooModelId (see line 3) still only covers two IDs. This can cause downstream typing friction. Suggest either:

  • Redefine RooModelId to derive from the model map (keyof typeof rooModels), placing the type after the constant; or
  • Extend the union to include "xai/grok-4-fast" and "deepseek/deepseek-chat-v3.1".

"xai/grok-4-fast": {
maxTokens: 30_000,
contextWindow: 2_000_000,
supportsImages: false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Description below calls Grok 4 Fast “multimodal”, but supportsImages is false. If images aren’t supported through the Roo provider for this free tier, consider removing “multimodal” from the description to prevent confusion.

inputPrice: 0,
outputPrice: 0,
description:
"Grok 4 Fast is xAI's latest multimodal model with SOTA cost-efficiency and a 2M token context window. (Note: prompts and completions are logged by xAI and used to improve the model.)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The description calls Grok 4 Fast “multimodal” but images are disabled. If that’s intentional (no image support via Roo), consider adjusting the wording to avoid “multimodal”.

inputPrice: 0,
outputPrice: 0,
description:
"Grok 4 Fast is xAI's latest multimodal model with SOTA cost-efficiency and a 2M token context window. (Note: prompts and completions are logged by xAI and used to improve the model.)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Grok 4 Fast is xAI's latest multimodal model with SOTA cost-efficiency and a 2M token context window. (Note: prompts and completions are logged by xAI and used to improve the model.)",
"Grok 4 Fast is xAI's latest model with SOTA cost-efficiency and a 2M token context window. (Note: prompts and completions are logged by xAI and used to improve the model.)",

inputPrice: 0,
outputPrice: 0,
description:
"DeepSeek-V3.1 is a large hybrid reasoning model (671B parameters, 37B active). It extends the DeepSeek-V3 base with a two-phase long-context training process, reaching up to 128K tokens, and uses FP8 microscaling for efficient inference.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Description says “up to 128K tokens” but contextWindow is 163,840. Consider aligning the description with the configured window (e.g., ~160K).

inputPrice: 0,
outputPrice: 0,
description:
"DeepSeek-V3.1 is a large hybrid reasoning model (671B parameters, 37B active). It extends the DeepSeek-V3 base with a two-phase long-context training process, reaching up to 128K tokens, and uses FP8 microscaling for efficient inference.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"DeepSeek-V3.1 is a large hybrid reasoning model (671B parameters, 37B active). It extends the DeepSeek-V3 base with a two-phase long-context training process, reaching up to 128K tokens, and uses FP8 microscaling for efficient inference.",
"DeepSeek-V3.1 is a large hybrid reasoning model (671B parameters, 37B active). It extends the DeepSeek-V3 base with a two-phase long-context training process, reaching up to 160K tokens, and uses FP8 microscaling for efficient inference.",

@poyhen
Copy link

poyhen commented Sep 27, 2025

any idea why i cant see grok 4 fast even tho i updated?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants