-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add cookie policy #8165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookie policy #8165
Conversation
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-m7j00folz-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and found some issues that need attention.
| <> | ||
| <div className="container mx-auto px-4 py-12 sm:px-6 lg:px-8"> | ||
| <div className="prose prose-lg mx-auto max-w-4xl dark:prose-invert"> | ||
| <p className="text-muted-foreground">Updated: September 18, 2025</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this date intentional? We're currently in 2024, but this shows 2025. Should this be "September 18, 2024"?
Note: The same issue appears in the subprocessors page at line 45.
| <p> | ||
| We use PostHog analytics cookies to understand how visitors interact with our website. This | ||
| helps us improve our services and user experience. Analytics cookies are placed only if you give | ||
| consent through our cookie banner. The lawful basis for processing these cookies is your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The policy mentions "Analytics cookies are placed only if you give consent through our cookie banner" but I don't see a cookie banner implementation in this PR. Is the consent mechanism being handled in a separate PR? If so, we should ensure they're coordinated.
| <div className="prose prose-lg mx-auto max-w-4xl dark:prose-invert"> | ||
| <p className="text-muted-foreground">Updated: September 18, 2025</p> | ||
|
|
||
| <h1 className="text-3xl font-bold tracking-tight sm:text-4xl md:text-5xl">Cookie Policy</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding internationalization support for this page. The rest of the application supports multiple languages (as seen in the package.nls.*.json files), and legal pages are particularly important to have in users' native languages.
| <> | ||
| <div className="container mx-auto px-4 py-12 sm:px-6 lg:px-8"> | ||
| <div className="prose prose-lg mx-auto max-w-4xl dark:prose-invert"> | ||
| <p className="text-muted-foreground">Updated: September 18, 2025</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hardcoding the update date, could we consider using a build-time constant or Git commit date? This would automatically update when the policy changes and prevent outdated dates.
| experience. | ||
| </p> | ||
|
|
||
| <div className="overflow-x-auto"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a caption element to improve table accessibility for screen readers:
|
|
||
| <p className="mt-4"> | ||
| <a | ||
| href="https://clerk.com/legal/privacy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the rest of the codebase (like in footer.tsx), consider moving these external URLs to a constants file. This makes maintenance easier and ensures consistency across the application.
Important
Adds a new Cookie Policy page and links it in the footer.
page.tsxinlegal/cookiesto describe cookie usage, types, and management.footer.tsx.This description was created by
for 987977c. You can customize this summary. It will automatically update as commits are pushed.