ux: Smaller and more subtle auto-approve UI #7894
Conversation
…maV2 crashes (#7594)
…or chat messages (#7790) * feat: add click-to-edit, ESC-to-cancel, and fix padding consistency - Enable click-to-edit for past messages by making message text clickable - Add ESC key handler to cancel edit mode in ChatTextArea - Fix padding consistency between past and queued message editors - Adjust right padding for edit mode to accommodate cancel button Fixes #7788 * fix: adjust padding and layout for ChatTextArea in edit mode * refactor: replace hardcoded pr-[72px] with standard Tailwind pr-20 class --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: Hannes Rudolph <[email protected]> Co-authored-by: daniel-lxs <[email protected]>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com> Co-authored-by: Bruno Bergher <[email protected]>
Co-authored-by: Roo Code <[email protected]> Co-authored-by: Hannes Rudolph <[email protected]> Co-authored-by: daniel-lxs <[email protected]>
feat: add taskSyncEnabled to userSettingsConfigSchema Co-authored-by: Roo Code <[email protected]>
chore: bump version to v1.75.0
…ls chart (#7830) Co-authored-by: Roo Code <[email protected]>
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and found that this successfully makes the auto-approve UI more subtle and scalable. The removal of the global checkbox in favor of All/None buttons is a good UX improvement.
Suggestions for Improvement:
-
Translation consistency: The pt-BR locale uses "YOLO" for
triggerLabelAllwhile all other locales use proper translations. While it adds personality, it might be worth keeping translations consistent for a professional UI. -
Accessibility enhancement: Consider adding
aria-describedbyattributes to the All/None buttons (around lines 262-299) to better communicate their purpose to screen reader users. -
Code duplication: The All/None button styles (lines 266-276 and 285-295) are identical. Consider extracting them into a shared constant or utility class to reduce duplication.
-
Test coverage: Consider adding unit tests for the new
AutoApproveDropdowncomponent to verify toggle behavior, All/None button functionality, and proper state management.
Overall, this is a clean implementation that achieves the goal of making the UI cleaner and more scalable. Great work!
hannesrudolph
added
the
Issue/PR - Triage
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| "disabledAriaLabel": "Aprovação automática desativada - selecione as opções primeiro" | ||
| "disabledAriaLabel": "Aprovação automática desativada - selecione as opções primeiro", | ||
| "triggerLabel_zero": "Nenhuma aprovação automática", | ||
| "triggerLabel_one": "1 aprovado automaticamente", |
There was a problem hiding this comment.
Typographical note: There appears to be a gender inconsistency here. Given that other strings use the feminine form (e.g., "Nenhuma aprovação automática"), consider using "1 aprovada automaticamente" instead of "1 aprovado automaticamente".
| "triggerLabel_one": "1 aprovado automaticamente", | |
| "triggerLabel_one": "1 aprovada automaticamente", |
| "disabledAriaLabel": "Aprovação automática desativada - selecione as opções primeiro", | ||
| "triggerLabel_zero": "Nenhuma aprovação automática", | ||
| "triggerLabel_one": "1 aprovado automaticamente", | ||
| "triggerLabel_other": "{{count}} aprovados automaticamente", |
There was a problem hiding this comment.
Typographical note: For consistency with the feminine form used elsewhere, consider changing "{{count}} aprovados automaticamente" to "{{count}} aprovadas automaticamente".
| "triggerLabel_other": "{{count}} aprovados automaticamente", | |
| "triggerLabel_other": "{{count}} aprovadas automaticamente", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "selectOptionsFirst": "請至少選擇以下一個選項以啟用自動批准", | ||
| "toggleAriaLabel": "切換自動批准", | ||
| "disabledAriaLabel": "自動批准已禁用 - 請先選擇選項", | ||
| "triggerLabel_zero": "無自動核准", |
There was a problem hiding this comment.
Typographical consistency: In the autoApprove section, the title and several labels use ‘自動批准’ while the trigger labels (triggerLabel_zero, triggerLabel_one, etc.) still use ‘自動核准’. It would be more consistent to update these trigger labels to '自動批准' unless there’s an intentional difference.
| "triggerLabel_zero": "無自動核准", | |
| "triggerLabel_zero": "無自動批准", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
Description
Makes the auto-approve less prominent, less noisy and a bit more scalable, in an effort to make the overall UI cleaner.
Changes in functionality:
The buttons may still be a bit too loud, but I'll consider that later.
Test Procedure
Screenshots / Videos
Important
Replaces
AutoApproveMenuwith a more subtleAutoApproveDropdownin the chat UI, enhancing functionality and updating translations across multiple languages.AutoApproveMenuwithAutoApproveDropdowninChatTextArea.tsxandChatView.tsx.AutoApproveMenu.tsxand its testAutoApproveMenu.spec.tsx.ApiConfigSelector.tsxto adjust styling for the new dropdown.AutoApproveDropdowncomponent with select all/none functionality inAutoApproveDropdown.tsx.ca,de,en,es,fr,hi,id,it,ja,ko,nl,pl,pt-BR,ru,tr,vi,zh-CN,zh-TW.ChatTextArea.tsxfor better integration of the new dropdown.This description was created by
for e8d1585. You can customize this summary. It will automatically update as commits are pushed.