fix: make nested git repository warning persistent with path info #7885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed from showWarningMessage to showErrorMessage for persistence - Modified getNestedGitRepository to return the specific path - Updated all i18n translations to include path parameter - Updated tests to match new error message format Fixes #7884
dosubot
bot
added
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
|
|
||
| if (nestedGitPaths.length > 0) { | ||
| // Get the first nested git repository path (remove .git/HEAD from the path) | ||
| const firstNestedPath = nestedGitPaths[0].path.replace(/[\/\\]\.git[\/\\]HEAD$/, "") |
There was a problem hiding this comment.
Consider adding a comment here explaining why we're stripping the .git/HEAD suffix from the path. Something like:
This would make the regex replacement purpose clearer for future maintainers.
| "Checkpoints are disabled because nested git repositories were detected in the workspace", | ||
| // The error message now includes the specific path of the nested repository | ||
| await expect(service.initShadowGit()).rejects.toThrowError( | ||
| /Checkpoints are disabled because a nested git repository was detected at:/, |
There was a problem hiding this comment.
Would it be helpful to add a more specific test that verifies the exact path is included in the error message? The current regex test confirms the format but doesn't verify the actual path. We could capture and assert the specific path like:
Checkpoints are disabled because a nested git repository was detected at: nested-project
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
- Fix path filtering to correctly expect 'file' type for HEAD files instead of 'folder' - Use Node's path module for robust cross-platform path manipulation - Update tests to match the corrected logic
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Sep 14, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7884
Summary
Enhanced the nested Git repository warning for checkpoints to be persistent and include the specific offending path inline.
Changes
showWarningMessagetoshowErrorMessagefor persistent notificationshasNestedGitRepositoriesmethod togetNestedGitRepositoryto return the specific pathTesting
Screenshots
The warning now shows as an error notification (persistent) with the specific path:
"Checkpoints are disabled because a nested git repository was detected at: [path]. To use checkpoints, please remove or relocate this nested git repository."
Important
Enhances nested Git repository warning to be persistent and include specific path, updates translations and tests accordingly.
showWarningMessagetoshowErrorMessageinShadowCheckpointService.tsfor persistent notifications.getNestedGitRepository()to return the specific path of the nested repository.ShadowCheckpointService.spec.tsto match the new error message format.This description was created by
for 014858f. You can customize this summary. It will automatically update as commits are pushed.