Skip to content

Fix: Improve WelcomeView styling and readability #7682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2025
Merged

Fix: Improve WelcomeView styling and readability #7682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123c61d
fix: improve WelcomeView styling and readability
daniel-lxs Sep 4, 2025
319b920
fix: remove undefined color class from incentive text
daniel-lxs Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions webview-ui/src/components/welcome/WelcomeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,21 +49,21 @@ const WelcomeView = () => {

return (
<Tab>
<TabContent className="flex flex-col gap-5 p-16">
<TabContent className="flex flex-col gap-4 p-6">
<RooHero />
<h2 className="mt-0 mb-0">{t("welcome:greeting")}</h2>
<h2 className="mt-0 mb-4 text-xl text-center">{t("welcome:greeting")}</h2>

<div className="font-bold">
<p>
<div className="text-base text-vscode-foreground py-2 px-2 mb-4">
<p className="mb-3 leading-relaxed">
<Trans i18nKey="welcome:introduction" />
</p>
<p>
<p className="mb-0 leading-relaxed">
<Trans i18nKey="welcome:chooseProvider" />
</p>
</div>

<div className="mb-4">
<p className="font-bold mt-0">{t("welcome:startRouter")}</p>
<p className="text-sm font-medium mt-4 mb-3">{t("welcome:startRouter")}</p>

<div>
{/* Define the providers */}
Expand Down Expand Up @@ -94,24 +94,26 @@ const WelcomeView = () => {
<a
key={index}
href={provider.authUrl}
className="flex-1 border border-vscode-panel-border hover:bg-secondary rounded-lg py-4 px-6 mb-2 flex flex-row gap-4 cursor-pointer transition-all no-underline text-inherit"
className="flex-1 border border-vscode-panel-border hover:bg-secondary rounded-md py-3 px-4 mb-2 flex flex-row gap-3 cursor-pointer transition-all no-underline text-inherit"
target="_blank"
rel="noopener noreferrer">
<div className="w-10 h-10">
<div className="w-8 h-8 flex-shrink-0">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon size reduction from 40x40px to 32x32px improves compactness, but have we considered the accessibility impact? Would it be worth making this configurable or ensuring it meets WCAG guidelines for minimum target sizes?

<img
src={`${imagesBaseUri}/${provider.slug}.png`}
alt={provider.name}
className="w-full h-full object-contain"
/>
</div>
<div>
<div className="font-bold text-vscode-foreground">{provider.name}</div>
<div className="text-sm font-medium text-vscode-foreground">
{provider.name}
</div>
<div>
<div className="text-xs text-vscode-descriptionForeground">
{provider.description}
</div>
{provider.incentive && (
<div className="text-xs font-bold">{provider.incentive}</div>
<div className="text-xs mt-1">{provider.incentive}</div>
)}
</div>
</div>
Expand All @@ -120,7 +122,7 @@ const WelcomeView = () => {
})()}
</div>

<p className="font-bold mt-8 mb-6">{t("welcome:startCustom")}</p>
<p className="text-sm font-medium mt-6 mb-3">{t("welcome:startCustom")}</p>
<ApiOptions
fromWelcomeView
apiConfiguration={apiConfiguration || {}}
Expand All @@ -131,8 +133,8 @@ const WelcomeView = () => {
/>
</div>
</TabContent>
<div className="sticky bottom-0 bg-vscode-sideBar-background p-5">
<div className="flex flex-col gap-1">
<div className="sticky bottom-0 bg-vscode-sideBar-background p-4 border-t border-vscode-panel-border">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition of the border-top here! To ensure sufficient contrast across all VSCode themes, could we verify that provides adequate visibility in both light and dark themes?

<div className="flex flex-col gap-2">
<div className="flex justify-end">
<VSCodeLink
href="#"
Expand Down
Loading