Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Aug 29, 2025

Important

Implement deferred task subscriptions in BridgeOrchestrator to handle tasks when not connected, updating Task class and adding tests for verification.

  • Behavior:
    • Implement deferred task subscriptions in BridgeOrchestrator by adding pendingTask to handle tasks when not connected.
    • Modify subscribeToTask() in BridgeOrchestrator to defer subscription if not connected.
    • Update handleConnect() in BridgeOrchestrator to subscribe to pending tasks upon connection.
  • Task Management:
    • Update Task class to use BridgeOrchestrator.subscribeToTask() in startTask() and resumeTaskFromHistory().
    • Remove bridge property from Task class, relying on BridgeOrchestrator for task subscriptions.
  • Testing:
    • Add tests in TaskChannel.test.ts to verify event mapping and listener setup.
    • Update Task.dispose.test.ts to check for proper cleanup of listeners and resources.
  • Misc:
    • Increment version in package.metadata.json from 1.64.0 to 1.65.0.
    • Minor logging improvements in ClineProvider.ts and api.ts.

This description was created by Ellipsis for 29f755e. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners August 29, 2025 09:23
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 29, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing deferred task subscriptions! The overall approach is solid, but I found some issues that need attention before merging.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 29, 2025
@cte cte merged commit 1d46bd1 into main Aug 29, 2025
10 checks passed
@cte cte deleted the cte/deferred-task-subscriptions branch August 29, 2025 09:43
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 29, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants