Skip to content

Conversation

@NaccOll
Copy link

@NaccOll NaccOll commented Aug 10, 2025

#6897

In multi-folder workspaces, mimic the history and index status, binding the dialog to the CWD when creating a new ChatView. This will prevent CWD switching during a conversation and further confusion.


Important

Use instance-specific workspacePath in CodeIndexManager and QdrantVectorStore to ensure consistent workspace handling.

  • Behavior:
    • In CodeIndexManager, use this.workspacePath if available instead of getWorkspacePath() in initialize() and _recreateServices().
    • In QdrantVectorStore, use this.workspaceRoot if available instead of getWorkspacePath() in deletePointsByMultipleFilePaths().
  • Classes:
    • Add workspaceRoot property to QdrantVectorStore to store the workspace path.
  • Misc:
    • Ensures consistent workspace path usage in multi-folder workspaces to prevent CWD switching during operations.

This description was created by Ellipsis for 58b0b64. You can customize this summary. It will automatically update as commits are pushed.

@NaccOll NaccOll requested review from cte, jr and mrubens as code owners August 10, 2025 16:21
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 10, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes to improve multi-folder workspace support. While the approach of using instance-specific workspace paths is good, I found some critical issues that need attention before merging.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 10, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 12, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 12, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Aug 12, 2025
@NaccOll NaccOll requested a review from daniel-lxs August 13, 2025 01:52
@NaccOll
Copy link
Author

NaccOll commented Aug 15, 2025

merge into #6904

@NaccOll NaccOll closed this Aug 15, 2025
@github-project-automation github-project-automation bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap Aug 15, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 15, 2025
@NaccOll NaccOll deleted the hotfix-multiple-fold-workspace-qdrant branch August 15, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR - Changes Requested size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants