Skip to content

fix: Fix Hugging Face provider setup not transitioning from welcome view #6173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix: Fix Hugging Face provider setup not transitioning from welcome view #6173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/types/src/global-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export const SECRET_STATE_KEYS = [
"codebaseIndexOpenAiCompatibleApiKey",
"codebaseIndexGeminiApiKey",
"codebaseIndexMistralApiKey",
"huggingFaceApiKey",
] as const satisfies readonly (keyof ProviderSettings)[]
export type SecretState = Pick<ProviderSettings, (typeof SECRET_STATE_KEYS)[number]>

Expand Down
10 changes: 10 additions & 0 deletions webview-ui/src/utils/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ function validateModelsAndKeysProvided(apiConfiguration: ProviderSettings): stri
return i18next.t("settings:validation.modelSelector")
}
break
case "huggingface":
if (!apiConfiguration.huggingFaceApiKey) {
return i18next.t("settings:validation.apiKey")
}
if (!apiConfiguration.huggingFaceModelId) {
return i18next.t("settings:validation.modelId")
}
break
}

return undefined
Expand Down Expand Up @@ -166,6 +174,8 @@ function getModelIdForProvider(apiConfiguration: ProviderSettings, provider: str
case "vscode-lm":
// vsCodeLmModelSelector is an object, not a string
return apiConfiguration.vsCodeLmModelSelector?.id
case "huggingface":
return apiConfiguration.huggingFaceModelId
default:
return apiConfiguration.apiModelId
}
Expand Down