Skip to content

Add jump icon for newly created files #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

Add jump icon for newly created files #5738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
644db56
feat: add jump icon for newly created files
Jul 15, 2025
bafb1ef
fix: remove duplicate file path display in newFileCreated case
roomote Jul 15, 2025
fe0e482
fix: address PR feedback for jump icon on new files
daniel-lxs Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions webview-ui/src/components/chat/ChatRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,7 @@ export const ChatRowContent = ({
isLoading={message.partial}
isExpanded={isExpanded}
onToggleExpand={handleToggleExpand}
onJumpToFile={() => vscode.postMessage({ type: "openFile", text: "./" + tool.path })}
/>
</>
)
Expand Down
15 changes: 14 additions & 1 deletion webview-ui/src/components/common/CodeAccordian.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ interface CodeAccordianProps {
isFeedback?: boolean
onToggleExpand: () => void
header?: string
onJumpToFile?: () => void
}

const CodeAccordian = ({
Expand All @@ -29,6 +30,7 @@ const CodeAccordian = ({
isFeedback,
onToggleExpand,
header,
onJumpToFile,
}: CodeAccordianProps) => {
const inferredLanguage = useMemo(() => language ?? (path ? getLanguageFromPath(path) : "txt"), [path, language])
const source = useMemo(() => code.trim(), [code])
Expand Down Expand Up @@ -68,7 +70,18 @@ const CodeAccordian = ({
</span>
</>
)}
<span className={`codicon codicon-chevron-${isExpanded ? "up" : "down"}`}></span>
{onJumpToFile && path && (
<span
className="codicon codicon-link-external mr-1"
style={{ fontSize: 13.5 }}
onClick={(e) => {
e.stopPropagation()
onJumpToFile()
}}
aria-label={`Open file: ${path}`}
/>
)}
{!onJumpToFile && <span className={`codicon codicon-chevron-${isExpanded ? "up" : "down"}`}></span>}
</ToolUseBlockHeader>
)}
{(!hasHeader || isExpanded) && (
Expand Down
Loading