-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add option to hide costs in VS Code extension #10438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All issues resolved. The
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
webview-ui/src/components/chat/context-management/CondensationResultRow.tsx
Show resolved
Hide resolved
|
@roomote fix the flagged issues and test failures |
Fixed the reported issues. All local checks passed. |
f06aa86 to
8af87ae
Compare
| */ | ||
| export function CondensationResultRow({ data }: CondensationResultRowProps) { | ||
| const { t } = useTranslation() | ||
| const { hideCosts } = useExtensionState() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hideCosts variable is destructured here but never used in the component. The cost badge (VSCodeBadge at lines 45-47) displays unconditionally. To implement the hide costs feature, wrap the cost badge with {!hideCosts && (...)} to conditionally render it based on user settings.
Fix it with Roo Code or mention @roomote and request a fix.
| cacheReads?: number | ||
| totalCost: number | ||
| contextTokens: number | ||
| hideCosts?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hideCosts property is added to the interface but is not destructured in the component parameters (lines 52-63). Without destructuring, the value is unavailable, and cost displays at lines 252 and 384-393 remain unconditional. Add hideCosts to the destructuring and use it to conditionally render cost elements.
Fix it with Roo Code or mention @roomote and request a fix.
|
@roomote try again. Address the PR comments and also look at the failing PR checks. |
Fixed the reported issues. Added |
Add setting to hide cost display in the VS Code extension UI, controllable at both user and organization levels.
Changes
hideCostsfield to organization and user settings in cloud typesshouldHideCosts()method in CloudSettingsService and StaticSettingsServicehideCoststo extension state and webview contexthideCostsflag:Organization-Level Control
Similar to task sync, this feature supports organization-level management:
View task on Roo Code Cloud