Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 2, 2026

Add setting to hide cost display in the VS Code extension UI, controllable at both user and organization levels.

Changes

  • Add hideCosts field to organization and user settings in cloud types
  • Implement shouldHideCosts() method in CloudSettingsService and StaticSettingsService
  • Add hideCosts to extension state and webview context
  • Update UI components to conditionally render costs based on hideCosts flag:
    • TaskHeader
    • ChatRow
    • TaskItemFooter
    • BrowserSessionRow
    • CondensationResultRow
  • Add toggle in CloudView for users to control cost visibility
  • Organization admins can manage cost visibility for their members (similar to task sync control)
  • Add English translations for hideCosts feature

Organization-Level Control

Similar to task sync, this feature supports organization-level management:

  • When a user is part of an organization, the organization settings take precedence
  • The toggle is disabled for organization members with a lock icon indicator
  • Individual users can control their own setting when not part of an organization

View task on Roo Code Cloud

@roomote
Copy link
Contributor Author

roomote bot commented Jan 2, 2026

Rooviewer Clock   See task on Roo Cloud

All issues resolved. The hideCosts feature is now correctly implemented with proper state management and conditional rendering.

  • CondensationResultRow.tsx: hideCosts is used but never imported from useExtensionState() - will cause ReferenceError at runtime
  • TaskHeader.tsx: hideCosts prop is used but not declared in TaskHeaderProps interface - TypeScript type mismatch
  • CondensationResultRow.tsx: hideCosts is imported but not used - costs display unconditionally
  • TaskHeader.tsx: hideCosts is in interface but not destructured or used - costs display unconditionally
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens
Copy link
Collaborator

mrubens commented Jan 2, 2026

@roomote fix the flagged issues and test failures

@roomote
Copy link
Contributor Author

roomote bot commented Jan 2, 2026

Fixaroo Clock   See task on Roo Cloud

Fixed the reported issues. All local checks passed.

View commit | Revert commit

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jan 2, 2026
@roomote roomote bot force-pushed the feature/ROO-364-hide-costs branch from f06aa86 to 8af87ae Compare January 2, 2026 16:34
*/
export function CondensationResultRow({ data }: CondensationResultRowProps) {
const { t } = useTranslation()
const { hideCosts } = useExtensionState()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hideCosts variable is destructured here but never used in the component. The cost badge (VSCodeBadge at lines 45-47) displays unconditionally. To implement the hide costs feature, wrap the cost badge with {!hideCosts && (...)} to conditionally render it based on user settings.

Fix it with Roo Code or mention @roomote and request a fix.

cacheReads?: number
totalCost: number
contextTokens: number
hideCosts?: boolean
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hideCosts property is added to the interface but is not destructured in the component parameters (lines 52-63). Without destructuring, the value is unavailable, and cost displays at lines 252 and 384-393 remain unconditional. Add hideCosts to the destructuring and use it to conditionally render cost elements.

Fix it with Roo Code or mention @roomote and request a fix.

@mrubens
Copy link
Collaborator

mrubens commented Jan 2, 2026

@roomote try again. Address the PR comments and also look at the failing PR checks.

@roomote
Copy link
Contributor Author

roomote bot commented Jan 2, 2026

Fixaroo Clock   See task on Roo Cloud

Fixed the reported issues. Added hideCosts to ExtensionState and wired it through to conditionally render cost displays in TaskHeader and CondensationResultRow. All local checks passed.

View commit | Revert commit

@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 8, 2026
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants