feat: ensure mcp-settings.json is always pretty-printed

[roomote]

Summary

This PR ensures that is always written in pretty-printed format (with indentation and line breaks) instead of being compacted to a single line. This makes the file much more readable and easier to manually edit.

Problem

When clicking the "always allow" button for an MCP server tool, the file gets compacted from pretty-printed format to a single line, making it difficult to read and edit manually.

Solution

1. Enhanced safeWriteJson utility: Added an optional parameter to support pretty-printing

   • Uses with indent for pretty-printing (suitable for small config files)
   • Maintains streaming approach for compact output (default behavior for backward compatibility)
   • No breaking changes - existing code continues to work as before

2. Updated all mcp-settings.json writes: All operations that write to now use :

   • Initial file creation in
   • Server config updates in
   • Server deletion in
   • Tool list updates in

3. Comprehensive test coverage:

   • 5 new unit tests for pretty-printing functionality
   • 1 integration test verifying JSON formatting preservation in McpHub
   • All existing tests continue to pass

Changes Made

Modified Files

• src/utils/safeWriteJson.ts: Added optional indent parameter support
• src/services/mcp/McpHub.ts: Updated all mcp-settings.json write calls to use indent=2
• src/utils/__tests__/safeWriteJson.test.ts: Added unit tests for pretty-printing
• src/services/mcp/__tests__/McpHub.spec.ts: Added integration test and updated mock

Testing

All tests pass successfully:

• ✅ 21 unit tests in safeWriteJson.test.ts (5 new tests added)
• ✅ 45 integration tests in McpHub.spec.ts (1 new test added)

Backward Compatibility

• Default behavior remains compact (no indent parameter = compact output)
• Only user-facing config files use pretty-printing
• No breaking changes to existing functionality

---

View task on Roo Code Cloud

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. No issues found.

The simplification properly addresses @hannesrudolph's feedback. safeWriteJson now always outputs pretty-printed JSON with 2-space indentation, removing the optional indent parameter. All existing callers remain compatible and benefit from the more readable output. The implementation is clean, well-tested, and appropriately removes the unused streaming approach.

Previous reviews

• 1b465be: Review #1

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[hannesrudolph]

@roomote we don't want the default behaviour to be compact as it was never intended to be compact. Compact was an accidental regression. Fix this PR description and function so that it simply does not compact it and that it also un-compacts it during a save that would have normally compacted it. Try to keep the codes simple and streamlined.

[roomote]

Fixaroo   See task on Roo Cloud

Fixed the reported issues. Simplified safeWriteJson to always pretty-print with 2-space indentation (no more optional parameter). All local checks passed.

_{View commit | Revert commit}