-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(prompts): strengthen native tool-use guidance #10311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+153
−32
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { getSharedToolUseSection } from "../tool-use" | ||
| import { TOOL_PROTOCOL } from "@roo-code/types" | ||
|
|
||
| describe("getSharedToolUseSection", () => { | ||
| describe("XML protocol", () => { | ||
| it("should include one tool per message requirement", () => { | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.XML) | ||
|
|
||
| expect(section).toContain("You must use exactly one tool per message") | ||
| expect(section).toContain("every assistant message must include a tool call") | ||
| }) | ||
|
|
||
| it("should include XML formatting instructions", () => { | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.XML) | ||
|
|
||
| expect(section).toContain("XML-style tags") | ||
| expect(section).toContain("Always use the actual tool name as the XML tag name") | ||
| }) | ||
| }) | ||
|
|
||
| describe("native protocol", () => { | ||
| it("should include one tool per message requirement when experiment is disabled", () => { | ||
| // No experiment flags passed (default: disabled) | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.NATIVE) | ||
|
|
||
| expect(section).toContain("You must use exactly one tool call per assistant response") | ||
| expect(section).toContain("Do not call zero tools or more than one tool") | ||
| }) | ||
|
|
||
| it("should include one tool per message requirement when experiment is explicitly disabled", () => { | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.NATIVE, { multipleNativeToolCalls: false }) | ||
|
|
||
| expect(section).toContain("You must use exactly one tool call per assistant response") | ||
| expect(section).toContain("Do not call zero tools or more than one tool") | ||
| }) | ||
|
|
||
| it("should NOT include one tool per message requirement when experiment is enabled", () => { | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.NATIVE, { multipleNativeToolCalls: true }) | ||
|
|
||
| expect(section).not.toContain("You must use exactly one tool per message") | ||
| expect(section).not.toContain("every assistant message must include a tool call") | ||
| expect(section).toContain("You must call at least one tool per assistant response") | ||
| expect(section).toContain("Prefer calling as many tools as are reasonably needed") | ||
| }) | ||
|
|
||
| it("should include native tool-calling instructions", () => { | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.NATIVE) | ||
|
|
||
| expect(section).toContain("provider-native tool-calling mechanism") | ||
| expect(section).toContain("Do not include XML markup or examples") | ||
| }) | ||
|
|
||
| it("should NOT include XML formatting instructions", () => { | ||
| const section = getSharedToolUseSection(TOOL_PROTOCOL.NATIVE) | ||
|
|
||
| expect(section).not.toContain("XML-style tags") | ||
| expect(section).not.toContain("Always use the actual tool name as the XML tag name") | ||
| }) | ||
| }) | ||
|
|
||
| describe("default protocol", () => { | ||
| it("should default to XML protocol when no protocol is specified", () => { | ||
| const section = getSharedToolUseSection() | ||
|
|
||
| expect(section).toContain("XML-style tags") | ||
| expect(section).toContain("You must use exactly one tool per message") | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.