Skip to content

Conversation

@requesty-JohnCosta27
Copy link
Contributor

@requesty-JohnCosta27 requesty-JohnCosta27 commented Dec 22, 2025

Closes: #10263

Description

Creates 2 custom events (with the same pattern as other provides that need base URL + API key to fetch models).

  • the first event is for actually refreshing the models (clicking the Refresh models button)
  • the second event is to communicate with the Requesty web view component and display the correct models. (Again, a very similar pattern to other providers).

Test Procedure

  • Select Requesty as your provider
  • See the full models list
  • Go to https://app.requesty.ai and in the Admin Panel, change the approved models list.
  • Go back to RooCode
  • Hit refresh models

You should now see an updated list of models.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Important

Adds custom handler for Requesty models with new events for fetching and refreshing models, updating Requesty.tsx to use these events.

  • Behavior:
    • Adds requestRequestyModels event in webviewMessageHandler.ts to fetch and refresh Requesty models using flushModels() and getModels().
    • Updates Requesty.tsx to use requestRequestyModels for refreshing models on mount and button click.
  • Events:
    • Adds requestyModels to ExtensionMessage and WebviewMessage types.
  • UI:
    • Requesty.tsx component now listens for requestyModels messages to update model list.

This description was created by Ellipsis for 2978a3c. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Dec 22, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 22, 2025

Rooviewer Clock   See task on Roo Cloud

Review completed. All previously flagged issues have been addressed.

  • Add error handling to requestRequestyModels handler in webviewMessageHandler.ts
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 22, 2025
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
daniel-lxs added a commit that referenced this pull request Dec 22, 2025
The existing flushRouterModels pattern doesn't work for Requesty because
it doesn't pass API credentials. This caused the 'Refresh Models' button
to return stale cached data instead of fresh models.

This fix:
- Adds a 'refresh: true' flag to requestRouterModels handler
- When refresh=true with a provider filter, flushes cache WITH credentials
- Updates Requesty.tsx to use this new pattern instead of flushRouterModels

The approach reuses existing infrastructure while ensuring the credential-
aware cache flush works for providers like Requesty that require apiKey
and baseUrl for API calls.

Supersedes #10264
@daniel-lxs
Copy link
Member

We recently merged some changes to be able to pull models from the API on demand and fully authenticated, I opened this PR #10273 to leverage that new functionality to fix the issue with the Requesty button.

Thank you for working on this PR and for showing us how to fix it properly.

@daniel-lxs daniel-lxs closed this Dec 22, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 22, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 22, 2025
@requesty-JohnCosta27
Copy link
Contributor Author

We recently merged some changes to be able to pull models from the API on demand and fully authenticated, I opened this PR #10273 to leverage that new functionality to fix the issue with the Requesty button.

Thank you for working on this PR and for showing us how to fix it properly.

Nice that's much cleaner! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Requesty refresh models button doesn't work

3 participants