Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Dec 20, 2025

Important

Enhances custom tool transpilation and bundling using esbuild-wasm, with new functions, tests, and dependency updates.

  • Behavior:
    • Adds copyEsbuildWasmFiles() in esbuild.ts to copy esbuild-wasm files for cross-platform transpilation.
    • Updates copyWasms() in esbuild.ts to include esbuild-wasm files.
    • Replaces esbuild with esbuild-wasm in custom-tool-registry.ts for tool transpilation.
    • Sets extension path in extension.ts for finding bundled esbuild-wasm.
  • Dependencies:
    • Adds esbuild-wasm and execa to package.json in packages/core.
    • Removes esbuild from dependencies in src/package.json.
  • Testing:
    • Adds esbuild-runner.spec.ts to test getEsbuildScriptPath() and runEsbuild() functions.
  • Misc:
    • Adds esbuild-runner.ts to handle esbuild-wasm CLI execution.

This description was created by Ellipsis for af6d5be. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners December 20, 2025 23:10
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. bug Something isn't working labels Dec 20, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 20, 2025

Rooviewer Clock   See task on Roo Cloud

All issues resolved. This commit consolidates esbuild-wasm copying into the copyWasms function and removes the now-unnecessary separate export. No new issues found.

  • Remove unused __dirname variable in test file
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 20, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 21, 2025
@cte cte merged commit 18acb96 into cte/core-package Dec 21, 2025
@cte cte deleted the cte/fix-esbuild-invocation branch December 21, 2025 04:42
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 21, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants