Skip to content

fix: normalize tool schemas for VS Code LM API to fix error 400 #10221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesrudolph merged 1 commit into from
Dec 20, 2025
Merged

fix: normalize tool schemas for VS Code LM API to fix error 400 #10221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/api/providers/__tests__/vscode-lm.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ describe("VsCodeLmHandler", () => {
}

// Verify sendRequest was called with tools in options
// Note: normalizeToolSchema adds additionalProperties: false for JSON Schema 2020-12 compliance
expect(mockLanguageModelChat.sendRequest).toHaveBeenCalledWith(
expect.any(Array),
expect.objectContaining({
Expand All @@ -348,6 +349,7 @@ describe("VsCodeLmHandler", () => {
properties: {
operation: { type: "string" },
},
additionalProperties: false,
},
},
],
Expand Down
7 changes: 6 additions & 1 deletion src/api/providers/vscode-lm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { type ModelInfo, openAiModelInfoSaneDefaults } from "@roo-code/types"

import type { ApiHandlerOptions } from "../../shared/api"
import { SELECTOR_SEPARATOR, stringifyVsCodeLmModelSelector } from "../../shared/vsCodeSelectorUtils"
import { normalizeToolSchema } from "../../utils/json-schema"

import { ApiStream } from "../transform/stream"
import { convertToVsCodeLmMessages, extractTextCountFromMessage } from "../transform/vscode-lm-format"
Expand All @@ -15,6 +16,8 @@ import type { SingleCompletionHandler, ApiHandlerCreateMessageMetadata } from ".

/**
* Converts OpenAI-format tools to VSCode Language Model tools.
* Normalizes the JSON Schema to draft 2020-12 compliant format required by
* GitHub Copilot's backend, converting type: ["T", "null"] to anyOf format.
* @param tools Array of OpenAI ChatCompletionTool definitions
* @returns Array of VSCode LanguageModelChatTool definitions
*/
Expand All @@ -24,7 +27,9 @@ function convertToVsCodeLmTools(tools: OpenAI.Chat.ChatCompletionTool[]): vscode
.map((tool) => ({
name: tool.function.name,
description: tool.function.description || "",
inputSchema: tool.function.parameters as Record<string, unknown> | undefined,
inputSchema: tool.function.parameters
? normalizeToolSchema(tool.function.parameters as Record<string, unknown>)
: undefined,
}))
}

Expand Down
Loading