Skip to content

Conversation

@dcbartlett
Copy link
Contributor

@dcbartlett dcbartlett commented Dec 18, 2025

Description

Fixes the Apply-Diff e2e test. Adds new tests for native tooling for apply-diff
Adds debug launch configuration for e2e tests.

Test Procedure

Run e2e test suite using pnpm test:run in the e2e app or with the debug launch profile.

Pre-Submission Checklist

  • [-] Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • [-] Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Important

Fixes apply-diff e2e test, adds native tool calling tests, and introduces debug configuration in vscode-e2e app.

  • Behavior:
    • Fixes apply-diff e2e test and adds new tests for native tool calling in apply-diff-native.test.ts.
    • Introduces debug launch configuration for e2e tests.
  • Tests:
    • Adds apply-diff-native.test.ts, execute-command-native.test.ts, list-files-native.test.ts, read-file-native.test.ts, search-files-native.test.ts, use-mcp-tool-native.test.ts, and write-to-file-native.test.ts for native tool calling.
    • Removes apply-diff.test.ts, execute-command.test.ts, list-files.test.ts, write-to-file.test.ts, and others, replacing them with native versions.
  • Misc:
    • Adds retries: 3 to mochaOptions in index.ts to improve test reliability.

This description was created by Ellipsis for c0160dc. You can customize this summary. It will automatically update as commits are pushed.

Closes #10647

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug Something isn't working labels Dec 18, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 18, 2025

Rooviewer Clock   See task on Roo Cloud

Reviewed at a0127d8. All previously flagged issues have been resolved.

  • Misleading comments about model/provider (e.g., "Claude Sonnet 4.5" comment with OpenAI model ID)
  • Native protocol verification doesn't actually assert hasNativeApiProtocol is true
  • Error handling test uses testFile.content instead of testFile.name for target file
  • New test files (execute-command-native.test.ts, list-files-native.test.ts, read-file-native.test.ts) missing hasNativeApiProtocol assertion
  • Remaining native test files (search-files-native.test.ts, use-mcp-tool-native.test.ts, write-to-file-native.test.ts) missing hasNativeApiProtocol assertion
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 18, 2025
@dcbartlett dcbartlett force-pushed the dbartlett/e2e-ntc-tests branch from 0121f71 to 836aa04 Compare December 18, 2025 13:42
@dcbartlett dcbartlett force-pushed the dbartlett/e2e-ntc-tests branch from bdd2326 to 58be120 Compare December 30, 2025 11:29
dcbartlett and others added 3 commits December 31, 2025 06:51
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jan 7, 2026
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR - Needs Preliminary Review size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Status: PR [Needs Prelim Review]

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Update e2e testing for native tool calling

4 participants