Skip to content

feat(evals): improve evals UI with tool groups and duration fix #10133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cte merged 4 commits into from
Dec 16, 2025
Merged

feat(evals): improve evals UI with tool groups and duration fix #10133

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0cabddb
fix: duration not reported in evals UI
hannesrudolph Dec 16, 2025
16d5f7c
feat(evals): add tool groups for aggregating tool usage stats
hannesrudolph Dec 16, 2025
99cfb04
fix(evals): prevent taskMetricsReady deadlock on disconnect
roomote Dec 16, 2025
b9aa6b5
fix(evals): ensure finished tasks get duration even without streaming…
hannesrudolph Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions apps/web-evals/src/app/runs/[id]/run.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,15 @@ export function Run({ run }: { run: Run }) {
void usageUpdatedAt
const metrics: Record<number, TaskMetrics> = {}

// Helper to calculate duration from database timestamps when streaming duration
// is unavailable (e.g., page was loaded after TaskStarted event was published)
const calculateDurationFromTimestamps = (task: TaskWithMetrics): number => {
if (!task.startedAt) return 0
const startTime = new Date(task.startedAt).getTime()
const endTime = task.finishedAt ? new Date(task.finishedAt).getTime() : Date.now()
return endTime - startTime
}

tasks?.forEach((task) => {
const streamingUsage = tokenUsage.get(task.id)
const dbMetrics = task.taskMetrics
Expand All @@ -331,26 +340,43 @@ export function Run({ run }: { run: Run }) {
// Check if DB metrics have meaningful values (not just default/empty)
const dbHasData = dbMetrics && (dbMetrics.tokensIn > 0 || dbMetrics.tokensOut > 0 || dbMetrics.cost > 0)
if (dbHasData) {
metrics[task.id] = dbMetrics
// If DB duration is 0 but we have timestamps, calculate from timestamps
const duration = dbMetrics.duration || calculateDurationFromTimestamps(task)
metrics[task.id] = { ...dbMetrics, duration }
} else if (streamingUsage) {
// Fall back to streaming values if DB is empty/stale
// Use streaming duration, or calculate from timestamps if not available
const duration = streamingUsage.duration || calculateDurationFromTimestamps(task)
metrics[task.id] = {
tokensIn: streamingUsage.totalTokensIn,
tokensOut: streamingUsage.totalTokensOut,
tokensContext: streamingUsage.contextTokens,
duration: streamingUsage.duration ?? 0,
duration,
cost: streamingUsage.totalCost,
}
}
} else if (streamingUsage) {
// For running tasks, use streaming values
// Use streaming duration, or calculate from task.startedAt if not available
// (happens when page loads after TaskStarted event was already published)
const duration = streamingUsage.duration || calculateDurationFromTimestamps(task)
metrics[task.id] = {
tokensIn: streamingUsage.totalTokensIn,
tokensOut: streamingUsage.totalTokensOut,
tokensContext: streamingUsage.contextTokens,
duration: streamingUsage.duration ?? 0,
duration,
cost: streamingUsage.totalCost,
}
} else if (task.startedAt) {
// Task has started (has startedAt in DB) but no streaming data yet
// This can happen when page loads after TaskStarted but before TokenUsageUpdated
metrics[task.id] = {
tokensIn: 0,
tokensOut: 0,
tokensContext: 0,
duration: calculateDurationFromTimestamps(task),
cost: 0,
}
}
})

Expand Down
134 changes: 71 additions & 63 deletions apps/web-evals/src/components/home/run.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,22 @@ import {
ScrollArea,
} from "@/components/ui"

// Tool group type (same as in runs.tsx)
type ToolGroup = {
id: string
name: string
icon: string
tools: string[]
}

type RunProps = {
run: EvalsRun
taskMetrics: EvalsTaskMetrics | null
toolColumns: ToolName[]
consolidatedToolColumns: string[]
toolGroups: ToolGroup[]
}

export function Run({ run, taskMetrics, toolColumns, consolidatedToolColumns }: RunProps) {
export function Run({ run, taskMetrics, toolColumns, toolGroups }: RunProps) {
const router = useRouter()
const [deleteRunId, setDeleteRunId] = useState<number>()
const [showSettings, setShowSettings] = useState(false)
Expand Down Expand Up @@ -143,6 +151,62 @@ export function Run({ run, taskMetrics, toolColumns, consolidatedToolColumns }:
[router, run.id],
)

// Helper to render a tool group cell
const renderToolGroupCell = (group: ToolGroup) => {
if (!taskMetrics?.toolUsage) {
return <span className="text-muted-foreground">-</span>
}

let totalAttempts = 0
let totalFailures = 0
const breakdown: Array<{ tool: string; attempts: number; rate: string }> = []

for (const toolName of group.tools) {
const usage = taskMetrics.toolUsage[toolName as ToolName]
if (usage) {
totalAttempts += usage.attempts
totalFailures += usage.failures
const rate =
usage.attempts > 0
? `${Math.round(((usage.attempts - usage.failures) / usage.attempts) * 100)}%`
: "0%"
breakdown.push({ tool: toolName, attempts: usage.attempts, rate })
}
}

if (totalAttempts === 0) {
return <span className="text-muted-foreground">-</span>
}

const successRate = ((totalAttempts - totalFailures) / totalAttempts) * 100
const rateColor =
successRate === 100 ? "text-muted-foreground" : successRate >= 80 ? "text-yellow-500" : "text-red-500"

return (
<Tooltip>
<TooltipTrigger>
<div className="flex flex-col items-center">
<span className="font-medium">{totalAttempts}</span>
<span className={rateColor}>{Math.round(successRate)}%</span>
</div>
</TooltipTrigger>
<TooltipContent>
<div className="text-xs">
<div className="font-semibold mb-1">{group.name}</div>
{breakdown.map(({ tool, attempts, rate }) => (
<div key={tool} className="flex justify-between gap-4">
<span>{tool}:</span>
<span>
{attempts} ({rate})
</span>
</div>
))}
</div>
</TooltipContent>
</Tooltip>
)
}

return (
<>
<TableRow className="cursor-pointer hover:bg-muted/50" onClick={handleRowClick}>
Expand Down Expand Up @@ -170,68 +234,12 @@ export function Run({ run, taskMetrics, toolColumns, consolidatedToolColumns }:
</div>
)}
</TableCell>
{consolidatedToolColumns.length > 0 && (
<TableCell className="text-xs text-center">
{taskMetrics?.toolUsage ? (
(() => {
// Calculate aggregated stats for consolidated tools
let totalAttempts = 0
let totalFailures = 0
const breakdown: Array<{ tool: string; attempts: number; rate: string }> = []

for (const toolName of consolidatedToolColumns) {
const usage = taskMetrics.toolUsage[toolName as ToolName]
if (usage) {
totalAttempts += usage.attempts
totalFailures += usage.failures
const rate =
usage.attempts > 0
? `${Math.round(((usage.attempts - usage.failures) / usage.attempts) * 100)}%`
: "0%"
breakdown.push({ tool: toolName, attempts: usage.attempts, rate })
}
}

const consolidatedRate =
totalAttempts > 0 ? ((totalAttempts - totalFailures) / totalAttempts) * 100 : 100
const rateColor =
consolidatedRate === 100
? "text-muted-foreground"
: consolidatedRate >= 80
? "text-yellow-500"
: "text-red-500"

return totalAttempts > 0 ? (
<Tooltip>
<TooltipTrigger>
<div className="flex flex-col items-center">
<span className="font-medium">{totalAttempts}</span>
<span className={rateColor}>{Math.round(consolidatedRate)}%</span>
</div>
</TooltipTrigger>
<TooltipContent>
<div className="text-xs">
<div className="font-semibold mb-1">Consolidated Tools:</div>
{breakdown.map(({ tool, attempts, rate }) => (
<div key={tool} className="flex justify-between gap-4">
<span>{tool}:</span>
<span>
{attempts} ({rate})
</span>
</div>
))}
</div>
</TooltipContent>
</Tooltip>
) : (
<span className="text-muted-foreground">-</span>
)
})()
) : (
<span className="text-muted-foreground">-</span>
)}
{/* Tool Group Columns */}
{toolGroups.map((group) => (
<TableCell key={group.id} className="text-xs text-center">
{renderToolGroupCell(group)}
</TableCell>
)}
))}
{toolColumns.map((toolName) => {
const usage = taskMetrics?.toolUsage?.[toolName]
const successRate =
Expand Down
Loading
Loading