Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review log creation / rotation #683

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Review log creation / rotation #683

merged 7 commits into from
Sep 2, 2024

Conversation

Romanitho
Copy link
Owner

Proposed Changes

Review log creation / rotation

Copy link
Contributor

github-actions bot commented Sep 2, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 6 2.24s
✅ JSON jsonlint 1 0 0.17s
✅ JSON prettier 1 0 0 0.39s
✅ JSON v8r 1 0 2.68s
✅ POWERSHELL powershell 4 0 10.1s
✅ POWERSHELL powershell_formatter 4 0 10.95s
⚠️ REPOSITORY checkov yes 1 14.75s
⚠️ REPOSITORY devskim yes 11 1.77s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 1.04s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 15.28s
✅ REPOSITORY kics yes no 1.57s
✅ REPOSITORY secretlint yes no 0.76s
✅ REPOSITORY syft yes no 0.41s
✅ REPOSITORY trivy yes no 7.66s
✅ REPOSITORY trivy-sbom yes no 0.83s
⚠️ REPOSITORY trufflehog yes 1 3.45s
⚠️ SPELL cspell 6 11 4.06s
✅ SPELL lychee 1 0 0.05s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Return $False
}
# create new file
Write-ToLog "New log file created"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KnifMelti just to be sure I didn't break anything? It seems better to me, but if you could confirm...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That remains to be seen 😄 but you're an expert, and I'm sleeping.
Anyway, you've merged it

@Romanitho Romanitho merged commit ee26305 into main Sep 2, 2024
2 checks passed
@Romanitho Romanitho deleted the fix-log-creation branch September 2, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants