Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation counter via an asset text file #506

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

Romanitho
Copy link
Owner

Proposed Changes

Add installation counter for statistics purpose only

Copy link
Contributor

github-actions bot commented Dec 5, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 7 1.78s
⚠️ MARKDOWN markdownlint 1 1 4 0.93s
✅ MARKDOWN markdown-link-check 1 0 11.35s
✅ MARKDOWN markdown-table-formatter 1 1 0 0.26s
✅ POWERSHELL powershell 2 0 5.11s
✅ POWERSHELL powershell_formatter 2 0 4.45s
⚠️ REPOSITORY checkov yes 1 10.85s
⚠️ REPOSITORY devskim yes 5 2.61s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 0.66s
⚠️ REPOSITORY git_diff yes 1 0.06s
✅ REPOSITORY grype yes no 10.4s
✅ REPOSITORY kics yes no 2.54s
✅ REPOSITORY secretlint yes no 0.77s
✅ REPOSITORY syft yes no 0.43s
✅ REPOSITORY trivy yes no 5.26s
✅ REPOSITORY trivy-sbom yes no 3.58s
⚠️ REPOSITORY trufflehog yes 1 3.79s
⚠️ SPELL cspell 4 58 4.88s
✅ SPELL lychee 1 0 2.57s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Romanitho Romanitho marked this pull request as ready for review December 5, 2023 14:32
@Romanitho Romanitho merged commit fb0c8a5 into main Dec 5, 2023
3 checks passed
@Romanitho Romanitho deleted the install-counter branch December 5, 2023 14:49
@KnifMelti
Copy link
Contributor

Too bad, I rolled out 1.18.4 on our domain today.. ..5000+ clients

@Romanitho
Copy link
Owner Author

😅
it's ok, it will be reported for next version ^^

@KnifMelti
Copy link
Contributor

Have you done any stress testing, how many can it handle per minute etc?

@KnifMelti
Copy link
Contributor

image

@Romanitho
Copy link
Owner Author

that's because the file doesn't exist yet.

@Romanitho
Copy link
Owner Author

After this small fix #509 it seems to work now 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants