Cleaning

[Romanitho]

Proposed Changes

• Cleaning things up

[github-actions]

🦙 MegaLinter status: ⚠️ WARNING

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
⚠️ COPYPASTE	jscpd	yes		7	2.24s
⚠️ MARKDOWN	markdownlint	1	1	4	1.04s
✅ MARKDOWN	markdown-link-check	1		0	8.75s
✅ MARKDOWN	markdown-table-formatter	1	1	0	0.31s
✅ POWERSHELL	powershell	3		0	6.02s
✅ POWERSHELL	powershell_formatter	3		0	4.16s
⚠️ REPOSITORY	checkov	yes		1	13.32s
⚠️ REPOSITORY	devskim	yes		4	2.07s
✅ REPOSITORY	dustilock	yes		no	0.04s
✅ REPOSITORY	gitleaks	yes		no	0.87s
⚠️ REPOSITORY	git_diff	yes		1	0.01s
✅ REPOSITORY	grype	yes		no	12.58s
✅ REPOSITORY	kics	yes		no	31.61s
✅ REPOSITORY	secretlint	yes		no	1.0s
✅ REPOSITORY	syft	yes		no	0.31s
✅ REPOSITORY	trivy	yes		no	4.62s
✅ REPOSITORY	trivy-sbom	yes		no	1.29s
⚠️ REPOSITORY	trufflehog	yes		1	5.74s
⚠️ SPELL	cspell	5		71	4.84s
✅ SPELL	lychee	1		0	1.85s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[Romanitho]

@FaserF any idea why MegaLinter cannot create the PR ?

[Romanitho]

I think first cleaning part is done

[FaserF]

@FaserF any idea why MegaLinter cannot create the PR ?

I will have a look into it

[KnifMelti]

(!(Test-Path "$WAUinstallPath\included_apps.txt")) maybe.. ..sorry for my curiosity 🤪

[Romanitho]

You're perfect... my favourite supervisor dinosaur 🦕 😍
Thanks again for reviewing and pointing out my mistakes.

[Romanitho]

and now, pure draft at the moment:
https://github.com/Romanitho/Winget-AutoUpdate/tree/draft-upgrade

[KnifMelti]

Could we have a Return $True or Return $False (if WinGet got updated or not) from Update-WinGet.ps1 it would be nice!
In that way one could from _WAU-mods.ps1 (Exit 1 to Re-run WAU from this script!) restart with the new WinGet

            #Test if _WAU-mods.ps1 exist: Mods for WAU (if Network is active/any Winget is installed/running as SYSTEM)
            $Mods = "$WorkingDir\mods"
            if (Test-Path "$Mods\_WAU-mods.ps1") {
                Write-ToLog "Running Mods for WAU..." "Yellow"
                & "$Mods\_WAU-mods.ps1"
                $ModsExitCode = $LASTEXITCODE
                #If _WAU-mods.ps1 has ExitCode 1 - Re-run WAU
                if ($ModsExitCode -eq 1) {
                    Write-ToLog "Re-run WAU"
                    Start-Process powershell -ArgumentList "-NoProfile -ExecutionPolicy Bypass -Command `"$WorkingDir\winget-upgrade.ps1`""
                    Exit
                }
            }

[KnifMelti]

...or better; if it was a success, fail or of it already was the latest one installed.

[KnifMelti]

I'm creating a propose branch with returns: success/fail/current

[FaserF]

@FaserF any idea why MegaLinter cannot create the PR ?

I will have a look into it

see here: #469