Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceUI added to handle some apps #437

Merged
merged 2 commits into from
Oct 19, 2023
Merged

ServiceUI added to handle some apps #437

merged 2 commits into from
Oct 19, 2023

Conversation

Romanitho
Copy link
Owner

Proposed Changes

  • Added ServiceUI to handle some apps that need user connected (Like paint.net)

@Romanitho Romanitho temporarily deployed to megalinter October 19, 2023 16:58 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 9 2.75s
✅ POWERSHELL powershell 4 0 11.28s
✅ POWERSHELL powershell_formatter 4 0 6.93s
⚠️ REPOSITORY checkov yes 1 29.99s
⚠️ REPOSITORY devskim yes 4 3.06s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 0.79s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.76s
✅ REPOSITORY kics yes no 17.03s
✅ REPOSITORY secretlint yes no 1.54s
✅ REPOSITORY syft yes no 0.16s
✅ REPOSITORY trivy yes no 4.36s
✅ REPOSITORY trivy-sbom yes no 3.22s
⚠️ REPOSITORY trufflehog yes 1 3.65s
⚠️ SPELL cspell 5 20 5.29s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Romanitho Romanitho marked this pull request as ready for review October 19, 2023 17:11
@Romanitho Romanitho merged commit 15e8508 into main Oct 19, 2023
3 checks passed
@Romanitho Romanitho deleted the ServiceUIv2 branch October 19, 2023 17:11
@KnifMelti
Copy link
Contributor

KnifMelti commented Oct 20, 2023

I've had problems with dnGrep.dnGrep, tested now with this and it just installed!

@KnifMelti
Copy link
Contributor

It updated correctly, but now it thinks it should be installed every time (black listing it again):

-> Available update : dnGrep 3.2.306 (x64). Current version : 3.2.306.0. Available version : 4.0.129.0.
-> Available update : Microsoft .NET Core Runtime - 2.1.30 (x64). Current version : < 3.1.25. Available version : 3.1.32.
-> Available update : Microsoft Visual C++ 2015-2022 Redistributable (x64) -. Current version : 14.36.32532.0. Available version : 14.38.32919.0.
-> Available update : Microsoft Visual C++ 2013 Redistributable (x64) - 12.0.. Current version : 12.0.30501.0. Available version : 12.0.40664.0.
-> Available update : Microsoft .NET SDK 6.0.415 (x64). Current version : > 3.1.426. Available version : 6.0.415.
-> Available update : Microsoft Visual C++ 2015-2022 Redistributable (x86) -. Current version : 14.36.32532.0. Available version : 14.38.32919.0.
-> Available update : UltraEdit. Current version : 30.1.0.23. Available version : 30.1.23.
05:11:31 - Microsoft Visual C++ 2013 Redistributable (x86) - 12.0. : Skipped upgrade because it is in the excluded app list
05:11:32 - Updating dnGrep 3.2.306 (x64) from 3.2.306.0 to 4.0.129.0...
05:11:36 - ##########   WINGET UPGRADE PROCESS STARTS FOR APPLICATION ID 'dnGrep.dnGrep'   ##########
05:11:36 - -> Running: Winget upgrade --id dnGrep.dnGrep --accept-package-agreements --accept-source-agreements -h


  ███▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  1024 KB / 8.19 MB
  ███████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  2.00 MB / 8.19 MB
  ██████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  3.00 MB / 8.19 MB
  ██████████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  4.00 MB / 8.19 MB
  ██████████████████▒▒▒▒▒▒▒▒▒▒▒▒  5.00 MB / 8.19 MB
  █████████████████████▒▒▒▒▒▒▒▒▒  6.00 MB / 8.19 MB
  █████████████████████████▒▒▒▒▒  7.00 MB / 8.19 MB
  █████████████████████████████▒  8.00 MB / 8.19 MB
  ██████████████████████████████  8.19 MB / 8.19 MB

No installed package found matching input criteria.
05:12:17 - ##########   WINGET UPGRADE PROCESS FINISHED FOR APPLICATION ID 'dnGrep.dnGrep'   ##########
05:12:17 - dnGrep 3.2.306 (x64) updated to 4.0.129.0 !

@KnifMelti
Copy link
Contributor

Ah, it was due to an old registry uninstall entry, now manually deleted!
✌️

@Romanitho
Copy link
Owner Author

Ahah. WAU becomes better and better 🤪

@Romanitho
Copy link
Owner Author

The next release will be 1.18.0
Huge changes. Still need to be tested to be set as stable

@Romanitho
Copy link
Owner Author

Now that ServiceUI is implemented, we could add an option to the upgrade/install behavior. Currently, the -h hide the Upgrade/installation. We could take advantage of the command without the -h if needed. This way, we can have a progress bar from the installer itself (if supported), like so:
image
-ShowUpgrades could be a new WAU option for new install and integrated to GPO.

@KnifMelti
Copy link
Contributor

Sounds good to have.

@KnifMelti
Copy link
Contributor

...but maybe a security challenge if the app then runs in in full graphic mode and presents a file browser or a help link...

@Romanitho
Copy link
Owner Author

That's very true.
But for personal installations maybe...
will not implement for now

@KnifMelti
Copy link
Contributor

KnifMelti commented Oct 27, 2023

Why not if it is a manageable setting?
Could be useful for home users, but it needs to be adapted to the -NotificationLevel too!

@Romanitho
Copy link
Owner Author

Yes, manageable by GPO 😅
The notification level need to be Full of course. Except if you want to display the progress bar without any notif, or only success 🤷🏼‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants