Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods Template/Functions and Lists in GPO + more... #263

Merged
merged 40 commits into from
Jan 30, 2023
Merged

Mods Template/Functions and Lists in GPO + more... #263

merged 40 commits into from
Jan 30, 2023

Conversation

KnifMelti
Copy link
Contributor

@KnifMelti KnifMelti commented Jan 18, 2023

Good to have!

@KnifMelti
Copy link
Contributor Author

Added saving Black/White List in GPO (not yet active in WAU) #256 (reply in thread)

@KnifMelti KnifMelti changed the title Small bits in Mods Template/Functions Mods Template/Functions and GPO Jan 19, 2023
@KnifMelti KnifMelti marked this pull request as draft January 19, 2023 01:00
@KnifMelti
Copy link
Contributor Author

@Romanitho couldn't make the -contain work with the array from GPO, switched to -match in:
if (($toUpdate -match $app.Id) -and $($app.Version) -ne "Unknown") and if (-not ($toSkip -match $app.Id) -and $($app.Version) -ne "Unknown"), ist that OK by you?

@Romanitho
Copy link
Owner

the thing with -match can make issue I think if different apps have same name parts, no ? like mozilla.firefox and mozilla.firefox.esr

@KnifMelti
Copy link
Contributor Author

You're absolutely right!
But I have tried and tried, but no go with -contains in the check of return Get-ItemProperty -Path "HKLM:\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate\BlackList" to if (-not ($toSkip -contains $app.Id) -and $($app.Version) -ne "Unknown")
The dinosaur has bitten the dust!
Do you have the time?

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Jan 19, 2023

ChatGPT solved my problem when I asked it and showed my code!
[EDIT] But now I'm back in the no go swamp... 🤯🤯🤯

@KnifMelti KnifMelti marked this pull request as ready for review January 20, 2023 02:59
@KnifMelti KnifMelti marked this pull request as draft January 20, 2023 03:01
@KnifMelti
Copy link
Contributor Author

Forgot to document this in README.MD...

@KnifMelti KnifMelti marked this pull request as ready for review January 20, 2023 03:43
Policies/WAU.admx Outdated Show resolved Hide resolved
@KnifMelti
Copy link
Contributor Author

ADML/ADMX revision 4.7 in this PR should close Issue #265:

image

@KnifMelti KnifMelti changed the title Mods Template/Functions and Lists in GPO Mods Template/Functions and Lists in GPO + more... Jan 26, 2023
@Romanitho
Copy link
Owner

Another big one :)

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Jan 28, 2023

Another big one :)

It started of as just bits in the Mods Template/Functions, but then evolved with #256 (reply in thread)...
...and corrections of v1.16.0 GPO bug found in #265 and Microsoft updating in #266
Maybe release WAU v1.16.1?

@Romanitho Romanitho merged commit 0245f7f into Romanitho:main Jan 30, 2023
@Romanitho
Copy link
Owner

Romanitho commented May 2, 2023

Quick question regarding GPO:
Should Application GPO Whitelist and Application GPO Blacklist mention that Get Black/White List from external Path (URL/UNC/GPO/Local) must be set to GPO ?

EDIT:
Or, what we can do is making Get Black/White List from external Path (URL/UNC/GPO/Local) facultative for GPO (as we can detect that Application GPO Whitelist or Application GPO Blacklist is set)

@Romanitho
Copy link
Owner

and I think there is a small typo:

image

@KnifMelti
Copy link
Contributor Author

Yes, the Interval should be at Logon.
Regarding GPO Whitelist/Blacklist it says in (but the more info, the better)
image

facultative is a unknown thing for me, if you have an idea of howto? then go for it!

@Romanitho
Copy link
Owner

yes, but not in the Application GPO Whitelist or Application GPO Blacklist. So if someone enable Application GPO Whitelist for instance, maybe it should be mentioned that Get Black/White List from external Path (URL/UNC/GPO/Local) needs to be set to "GPO" ?

@Romanitho
Copy link
Owner

Romanitho commented May 2, 2023

by the way, I like this:

image

from this:

image

I wonder if this could not be settable from registry key as well. And of course, if settings are changed they get applied on next scheduled task run, like you did with GPO

@KnifMelti
Copy link
Contributor Author

Just remember that you can't set anything directly in registry under HKLM\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate
It must be handled by editing the Policies.

@Romanitho
Copy link
Owner

yes, I was talking about setting WAU_UpdatesInterval and WAU_UpdatesAtTime in the SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Winget-AutoUpdate part.

@Romanitho
Copy link
Owner

anyway, your GPO with whitelist by GPO works like a charm. Currently testing on a customer environment 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants