Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override mods done (+error handling) #245

Merged
merged 14 commits into from
Dec 15, 2022
Merged

Override mods done (+error handling) #245

merged 14 commits into from
Dec 15, 2022

Conversation

KnifMelti
Copy link
Contributor

More choices for everyone...

@JonNesovic
Copy link

Thank you for implementing my suggestion!

@KnifMelti
Copy link
Contributor Author

Still, even after upgrading like you did (but with an Adobe.Acrobat.Reader.64-bit-override.txt mod containing "/sAll /rs /msi EULA_ACCEPT=YES DISABLEDESKTOPSHORTCUT=1") from version 22.002.20212 to 22.003.20258 I still get a shortcut (Adobe Acrobat.lnk ???) on the Desktop but the EULA is gone...
...could be my machine.

The Adobe install log with all the correct parameters from WAU running with an -override txt mod:

[2022-12-09 03:43:39] Adobe SFX 10.0.0.1 logging started.
[2022-12-09 03:43:39] CommandParam CmdLine: "C:\WINDOWS\TEMP\WinGet\defaultState\Adobe.Acrobat.Reader.64-bit.22.003.20258\AcroRdrDCx642200320258_MUI.exe" /sAll /rs /msi EULA_ACCEPT=YES DISABLEDESKTOPSHORTCUT=1
[2022-12-09 03:43:39] CommandParam passToSetup_  : /sAll /rs /msi EULA_ACCEPT=YES DISABLEDESKTOPSHORTCUT=1
[2022-12-09 03:43:39] CommandParam bSilent_
[2022-12-09 03:43:39] TempFolder: C:\WINDOWS\TEMP\
[2022-12-09 03:43:39] Support folder: C:\ProgramData\Adobe\Temp\10937
[2022-12-09 03:43:39] Extracting: C:\ProgramData\Adobe\Temp\10937\config.bin
[2022-12-09 03:43:39] CheckSystemRequirements os,sp = 62 0 osString = 62W6, physicalMemory (16323) = 16384
[2022-12-09 03:43:39] Adding extracted installer size to the total size: 1118
[2022-12-09 03:43:39] CheckDiskSpace...
[2022-12-09 03:43:39] Required size in MB:  1578
[2022-12-09 03:43:39] Available disk space in MB:  82265
[2022-12-09 03:43:39] IsAlreadyInstalled...
[2022-12-09 03:43:39] SetupInstaller...
[2022-12-09 03:43:39] Extracting: C:\ProgramData\Adobe\Temp\10937\installer.bin
[2022-12-09 03:43:44] Attempted to cleanup folder failed: C:\Program Files\Common Files\Adobe\Acrobat\Setup\{AC76BA86-1033-FF00-7760-BC15014EA700}\RDC
[2022-12-09 03:43:44] Installer folder: C:\Program Files\Common Files\Adobe\Acrobat\Setup\{AC76BA86-1033-FF00-7760-BC15014EA700}\RDC
[2022-12-09 03:43:44] Extracting files from Archive: C:\ProgramData\Adobe\Temp\10937\installer.bin
[2022-12-09 03:44:23] StartInstaller...
[2022-12-09 03:44:23] CreateProcess cmdLine: "C:\Program Files\Common Files\Adobe\Acrobat\Setup\{AC76BA86-1033-FF00-7760-BC15014EA700}\RDC\setup.exe" /sAll /rs /msi EULA_ACCEPT=YES DISABLEDESKTOPSHORTCUT=1 DISABLE_CACHE=1
[2022-12-09 03:45:26] Installer finished with exit code: 0
[2022-12-09 03:45:26] Cleanup...
[2022-12-09 03:45:26] Program finished with exit code: 0

@KnifMelti
Copy link
Contributor Author

Thank you @Nesovj for the great idea! 👌

@JonNesovic
Copy link

I bet it is the issue with the latest release: https://www.adobe.com/devnet-docs/acrobatetk/tools/ReleaseNotesDC/continuous/dccontinuousoct2022qfe.html#bug-fixes

The computer I tested on had Adobe 32 bit originally installed with an .mst transforms file.

I tried on a blank VM and get the desktop shortcut with --override only on the latest version of Adobe.Acrobat.Reader.64.

Good thing you already have the AppID-installed.ps1 mod!

#Delete Public Desktop Shortcut
$FileName = "$env:PUBLIC\Desktop\Adobe Acrobat.lnk"

if (Test-Path $FileName) {
  Remove-Item -Path $FileName -Force
}

@Romanitho
Copy link
Owner

Wow guys, you're making it better and better... thank you for your hard work 👍

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 9, 2022

We're waiting for you @Romanitho with #228 #235 etc, etc, etc... 😁
...but, you'll soon have another life to live ❤️❤️❤️

@KnifMelti KnifMelti marked this pull request as draft December 10, 2022 23:34
@KnifMelti KnifMelti changed the title Override mods done Override mods done (+error handling) Dec 11, 2022
@KnifMelti KnifMelti marked this pull request as ready for review December 11, 2022 00:33
@KnifMelti KnifMelti mentioned this pull request Dec 11, 2022
@KnifMelti KnifMelti marked this pull request as draft December 11, 2022 10:18
@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 11, 2022

Can't get the Errorlevel from Exit 1 in Winget-Upgrade.ps1 over to User-Run.ps1, leaving the $NotifLocale.local.outputs.output[9].message to $MessageType = "success" (giving up)...

@KnifMelti KnifMelti marked this pull request as ready for review December 11, 2022 11:09
@KnifMelti KnifMelti marked this pull request as draft December 11, 2022 11:21
@KnifMelti
Copy link
Contributor Author

Working on an old school solution, taking a break now...

@KnifMelti KnifMelti marked this pull request as ready for review December 11, 2022 16:42
@KnifMelti KnifMelti marked this pull request as draft December 11, 2022 17:05
@KnifMelti KnifMelti marked this pull request as ready for review December 11, 2022 17:41
@KnifMelti KnifMelti marked this pull request as draft December 11, 2022 21:02
@KnifMelti KnifMelti marked this pull request as ready for review December 11, 2022 21:22
@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 11, 2022

Now, really done! 😁 (EDIT: NOT...)

@KnifMelti KnifMelti marked this pull request as draft December 11, 2022 23:51
@KnifMelti KnifMelti marked this pull request as ready for review December 12, 2022 00:29
@KnifMelti
Copy link
Contributor Author

END.

@KnifMelti KnifMelti marked this pull request as draft December 12, 2022 01:06
@KnifMelti KnifMelti marked this pull request as ready for review December 12, 2022 01:19
@KnifMelti
Copy link
Contributor Author

Just like Romanitho/Winget-Install#64 (comment)

@Romanitho Romanitho merged commit dbdfb1e into Romanitho:main Dec 15, 2022
@KnifMelti KnifMelti deleted the Override branch December 15, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants