Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods path #232

Merged
merged 37 commits into from
Dec 7, 2022
Merged

Mods path #232

merged 37 commits into from
Dec 7, 2022

Conversation

KnifMelti
Copy link
Contributor

External Mods done...

@Romanitho
Copy link
Owner

WAU becomes very sophisticated ^^ but winget needs to work properly for that :p

@KnifMelti
Copy link
Contributor Author

Today MS have a winget problem: Failed in attempting to update the source: winget (via winget direct)
But, it doesn't affect anything in WAU ;)
This external/central mods/list logic is now rolled out to 100+ clients and already done it's job perfectly!
Working on Winget-Install adoptation too.

@Romanitho
Copy link
Owner

yes. winget has issue for 3 days now... :/

@KnifMelti KnifMelti marked this pull request as draft November 8, 2022 00:03
@KnifMelti KnifMelti marked this pull request as ready for review November 8, 2022 00:10
@KnifMelti
Copy link
Contributor Author

For update checks: Weekly is too seldom, daily is too often in our mind...
...with 5000+ clients the performance impact can be a problem when using an external list/mods server.

@KnifMelti KnifMelti marked this pull request as draft November 26, 2022 15:36
@KnifMelti
Copy link
Contributor Author

#239

@KnifMelti KnifMelti marked this pull request as ready for review November 26, 2022 21:08
@Romanitho
Copy link
Owner

Romanitho commented Nov 29, 2022

Looks really nice :)
Just tell me when it's OK for you and I merge.

@KnifMelti
Copy link
Contributor Author

We've been running it for 2-3 weeks now without a problem, so anytime tou like 🤞

@KnifMelti
Copy link
Contributor Author

Need to implement #241 first...

@Romanitho
Copy link
Owner

ok :)

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Dec 4, 2022

This PR has one breaking change from the way AppID-upgrade.ps1/AppID-install.ps1 were used earlier .
Now:

  • AppID-upgrade.ps1/AppID-install.ps1 : run during upgrade/install (before install check)
  • AppID-installed.ps1 : runs after upgrade/install has been confirmed

Already existing AppID-upgrade.ps1/AppID-install.ps1 must be tested if they work (they earlier executed after upgrade/install had been confirmed)!

@KnifMelti KnifMelti marked this pull request as ready for review December 4, 2022 01:39
@Romanitho Romanitho merged commit 4a8a48c into Romanitho:main Dec 7, 2022
@Romanitho
Copy link
Owner

👌

@Romanitho
Copy link
Owner

thanks for this hard work!!

@KnifMelti KnifMelti deleted the ModsPath branch December 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants