VM tweak to allow large hard-coded arrays. #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is, the VM will try to push all elements of a hard-coded array to the stack ahead of the
NewArray
instruction, which causes stack overflow exceptions if the array has ≥250 elements at most, which is a problem when hard-coding a lookup table for e.g. CRC-16-CCITT.This change modifies the compiler to insert a newFlushArr
instruction after every 32 elements (if the array is has more than 32 elements) to avoid overflows. This can be easily adjusted by changing this line:Edit: I've realized it's both simpler and more sensible to just initialize arrays the same way objects are created. It solves the problem and minimizes the stack space required to create arbitrarily large arrays. Implementation has been changed accordingly. No new instructions needed.