do not disable tls verification in init #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLS verification for some reason is disabled by default globally by the download package. This is done at init, which means simply importing the package has the very dangerous, unexpected side effect of removing TLS verification for any http client elsewere in the codebase using the default http client. Rather than disable TLS verification globally at init time, instead do it as part of the bootstrap/run process so that applications using this module do not inadvertently decrease their security.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS verification for some reason is disabled by default globally by the
download package. This is done at init, which means simply importing the
package has the very dangerous, unexpected side effect of removing TLS
verification for any http client elsewere in the codebase using the
default http client.
Rather than disable TLS verification globally at init time, instead do
it as part of the bootstrap/run process so that applications using this
module do not inadvertently decrease their security.