Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Adds Sensors classes #683

Merged
merged 133 commits into from
Sep 12, 2024
Merged

ENH: Adds Sensors classes #683

merged 133 commits into from
Sep 12, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Sep 8, 2024 •
edited
Loading

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

We are finally adding the Sensor class and its children!!

Breaking change

  • Yes
  • No

Additional information

This work was mainly done by @MateusStano and it's almost ready, just needs a final double check.

MateusStano and others added 30 commits April 1, 2024 18:51
@MateusStano
ENH: sensors class
e403872
@MateusStano
ENH: add accelerometer and gyroscope classes
6cd3598
@MateusStano
ENH: euler to quaternions tool function
3b81777
@MateusStano
ENH: add sensors to other classes
4c8aa13
@MateusStano
ENH: prints and sensors draw
09e0d75
@MateusStano
ENH: add sensors to parachutes
38866f4
@MateusStano
TST: add sensors fixtures
b386e38
@MateusStano
TST: add sensors tests
6ff2dde
@MateusStano
DEV: sensors testing notebook
5ae01b9
@MateusStano
ENH: add option to add noise to each axis seperatly
1dd5781
@MateusStano
MNT: run isort
943542a
@MateusStano
ENH: calculate u_dot only once for all sensors
28ebc46
@MateusStano
MNT: change measured_values to measured_data
378bb54
@MateusStano
TST: unite gyro and accel tests
d8440f2
@MateusStano @phmbressan
Update rocketpy/plots/rocket_plots.py
99f445f 
Co-authored-by: Pedro Henrique Marinho Bressan <[email protected]>
@MateusStano
ENH: normalize quaternions for transform matrix
4db26f0
@MateusStano
TST: lower tolerances
4356af7
@MateusStano
BUG: handle zero norm differently due to numpy.float64
5c37f06
@MateusStano
MNT: quantization typos
8d64998
@MateusStano
DOCS: mention Hadamard product
28da8f3
@MateusStano
DOC: complete sensors class docstrings
cef72a0
@MateusStano
Squashed commit of the following:
5f8f1f4 
commit b18ae9c
Merge: 67515f6 9a8e0c1
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 25 18:15:24 2024 -0400

    Merge branch 'develop' into bug/airbrakes-postprocess

commit 67515f6
Author: MateusStano <[email protected]>
Date:   Thu Apr 25 23:02:11 2024 +0200

    ENH: automatically disable time overshoot for controllers

commit f60c53b
Merge: 4974e8d 3df7586
Author: MateusStano <[email protected]>
Date:   Thu Apr 25 22:53:10 2024 +0200

    Merge branch 'bug/airbrakes-postprocess' of https://github.com/RocketPy-Team/RocketPy into bug/airbrakes-postprocess

commit 4974e8d
Author: MateusStano <[email protected]>
Date:   Thu Apr 25 22:52:48 2024 +0200

    BUG: initialize state derivatives for controllers

commit a49baf4
Author: MateusStano <[email protected]>
Date:   Thu Apr 25 22:52:13 2024 +0200

    MNT: move controller initialization to private method

commit 9a8e0c1
Merge: 14375ed 2cbaa77
Author: MateusStano <[email protected]>
Date:   Thu Apr 25 15:37:05 2024 -0300

    Merge pull request #580 from RocketPy-Team/mnt/modularize-rocket-draw

    MNT: Modularize Rocket Draw

commit 2cbaa77
Merge: 822a89e 14375ed
Author: MateusStano <[email protected]>
Date:   Thu Apr 25 11:44:22 2024 -0300

    Merge branch 'develop' into mnt/modularize-rocket-draw

commit 3df7586
Merge: bf8c68b 14375ed
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 25 06:49:58 2024 -0400

    Merge branch 'develop' into bug/airbrakes-postprocess

commit 14375ed
Merge: c31c6f8 b899064
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 25 06:47:36 2024 -0400

    Merge pull request #588 from RocketPy-Team/enh/exponential-backoff-decorator

    ENH: Exponential backoff decorator (fix #449)

commit c31c6f8
Merge: a011c5a 684b997
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 25 06:45:26 2024 -0400

    Merge pull request #587 from RocketPy-Team/mnt/delete-cached-property

    DEP: delete deprecated rocketpy.tools.cached_property

commit b899064
Author: Gui-FernandesBR <[email protected]>
Date:   Fri Apr 19 12:13:23 2024 -0400

    DEV: adds PR 588 to the CHANGELOG

commit a8a185e
Author: Gui-FernandesBR <[email protected]>
Date:   Fri Apr 19 12:08:58 2024 -0400

    TST: Fix tests with Environment class after exponential_backoff decorator was used

commit d0fbcd7
Author: Gui-FernandesBR <[email protected]>
Date:   Fri Apr 19 12:07:45 2024 -0400

    MNT: Refactor code to use the exponential_backoff decorator

commit ccd78af
Author: Gui-FernandesBR <[email protected]>
Date:   Fri Apr 19 12:07:17 2024 -0400

    ENH: Add exponential backoff decorator to tools.py

commit 684b997
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 18 21:47:19 2024 -0400

    DEV: Adds PR 587 to the CHANGELOG.md

commit bb0f46a
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 18 21:41:38 2024 -0400

    MNT: refactors cached_property imports

commit afb3b32
Author: dyu056 <[email protected]>
Date:   Fri Jan 26 00:35:36 2024 +1300

    Completed changes

commit bf8c68b
Merge: aaa3f7b a011c5a
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 18 21:17:06 2024 -0400

    Merge branch 'develop' into bug/airbrakes-postprocess

commit a011c5a
Merge: 624cc15 6b26f61
Author: Gui-FernandesBR <[email protected]>
Date:   Thu Apr 18 15:12:40 2024 -0400

    Merge pull request #585 from RocketPy-Team/enh/swap-diff-for-flow-rate

    BUG: Swap `rocket.total_mass.differentiate` for `motor.total_mass_flow rate`

commit 6b26f61
Author: MateusStano <[email protected]>
Date:   Wed Apr 17 22:19:16 2024 +0200

    DEV: changelog

commit 8ee2c95
Author: MateusStano <[email protected]>
Date:   Wed Apr 17 22:16:59 2024 +0200

    ENH: create rocket total_mass_flow_rate attribute

commit aaa3f7b
Author: MateusStano <[email protected]>
Date:   Mon Apr 15 16:52:49 2024 +0200

    DOCS: change accelerations names in docs

commit 7fe3d0b
Author: MateusStano <[email protected]>
Date:   Mon Apr 15 16:12:39 2024 +0200

    ENH: optmize post process loop

commit a66fc53
Author: MateusStano <[email protected]>
Date:   Mon Apr 15 15:18:37 2024 +0200

    ENH: add reset function

commit b9a97a4
Author: MateusStano <[email protected]>
Date:   Mon Apr 15 15:06:01 2024 +0200

    ENH: add warning for improper time_overshoot

commit 830ea15
Author: MateusStano <[email protected]>
Date:   Mon Apr 15 15:05:31 2024 +0200

    ENH: refactor retrieve arrays cached properties and controller sim post processing

commit e2a94c8
Author: MateusStano <[email protected]>
Date:   Tue Apr 9 18:03:08 2024 +0200

    TST: fix tests

commit e5c7533
Author: MateusStano <[email protected]>
Date:   Tue Apr 9 17:59:22 2024 +0200

    ENH: use mass_flow_rate instead of differentiate

commit 822a89e
Merge: e3e1a59 624cc15
Author: MateusStano <[email protected]>
Date:   Sun Apr 7 13:52:02 2024 +0200

    Merge branch 'develop' into mnt/modularize-rocket-draw

commit e3e1a59
Author: MateusStano <[email protected]>
Date:   Thu Apr 4 14:53:37 2024 +0200

    DEV: fix changelog order

commit 624cc15
Merge: 0a4d89b 61bf4d7
Author: Pedro Henrique Marinho Bressan <[email protected]>
Date:   Tue Apr 2 14:23:05 2024 -0300

    Merge pull request #565 from RocketPy-Team/doc/environment-docstring

    DOC: Improvements of Environment docstring phrasing.

commit 61bf4d7
Author: Pedro Bressan <[email protected]>
Date:   Mon Apr 1 15:00:10 2024 -0300

    MNT: add docs change to CHANGELOG.

commit 9c1a461
Author: Pedro Bressan <[email protected]>
Date:   Mon Apr 1 14:47:03 2024 -0300

    DOC: fix typing issues regarding Environment docs.

commit 4776208
Author: Pedro Henrique Marinho Bressan <[email protected]>
Date:   Fri Mar 29 08:47:18 2024 -0300

    DOC: Update Longitude value ranges.

    Co-authored-by: Gui-FernandesBR <[email protected]>

commit 32a28c1
Merge: 27dd73d 0a4d89b
Author: Pedro Henrique Marinho Bressan <[email protected]>
Date:   Thu Mar 28 18:26:46 2024 -0300

    Merge branch 'develop' into doc/environment-docstring

commit 27dd73d
Author: Pedro Bressan <[email protected]>
Date:   Thu Mar 28 18:24:23 2024 -0300

    DOC: standardize grammar on time zones.

commit 4b42c9e
Author: Pedro Bressan <[email protected]>
Date:   Thu Mar 28 18:20:01 2024 -0300

    DOC: clarify timezones and dates Environment docs.

commit 95b61ef
Author: Pedro Bressan <[email protected]>
Date:   Thu Mar 28 16:38:17 2024 -0300

    DOC: specify latitude and longitude defaults.

commit 6b84c03
Author: Pedro Bressan <[email protected]>
Date:   Mon Mar 25 19:53:37 2024 -0300

    DOC: improve wording of Environment init.

    Co-authored-by: Gui-FernandesBR <[email protected]>

commit 826efcc
Author: Pedro Bressan <[email protected]>
Date:   Sun Mar 24 16:47:14 2024 -0300

    DOC: specify datum as optional.

commit a2aa714
Author: Pedro Bressan <[email protected]>
Date:   Sun Mar 24 16:41:39 2024 -0300

    DOC: add examples and improvements to Environment gravity docstring.

commit 51bdd91
Author: MateusStano <[email protected]>
Date:   Sun Mar 24 15:14:45 2024 +0100

    MNT: changelog

commit 6805e32
Author: MateusStano <[email protected]>
Date:   Sun Mar 24 14:05:00 2024 +0100

    MNT: refactor rocket drawing plot methods

commit 3cc91e7
Merge: f637a9d 65b3315
Author: Pedro Henrique Marinho Bressan <[email protected]>
Date:   Thu Feb 29 20:06:09 2024 -0300

    Merge branch 'develop' into doc/environment-docstring

commit f637a9d
Author: Pedro Bressan <[email protected]>
Date:   Thu Feb 29 17:49:38 2024 -0300

    STY: run black for code linting.

commit 9198ac7
Author: Pedro Bressan <[email protected]>
Date:   Thu Feb 29 17:46:23 2024 -0300

    DOC: phrasing improvements of Environment docstring.
@MateusStano
MNT: fix component repr for sensors
9a6b052
@MateusStano
ENH: add _attatched_rockets to sensors
7953cb0
@MateusStano
ENH: add sensors saving methods
5a37553
@MateusStano
MNT: simplify sensors repr
09ea252
@MateusStano
ENH: use _save_data in accel and gyro
9851392
@MateusStano
ENH: improve accelerometer export
0f81bc3
@MateusStano
ENH: imrpove gyroscope export
a740fc2
@MateusStano
ENH: add sensor initialization
cf6c26d
MateusStano and others added 10 commits June 6, 2024 19:38
@MateusStano
ENH: rename test files
1d5e769
@MateusStano
ENH: change from celsius to kelvin
7f0fe70
@MateusStano
TST: fix celsius to kelvin convertion
0b779f2
@MateusStano
Merge pull request #608 from RocketPy-Team/enh/barometer
af410b6 
ENH: Barometer, ScalarSensors and InertialSensors
@MateusStano
merge develop
5db0ef3
@MateusStano
MNT: unecessary variable
5d806c6
@MateusStano
Merge branch 'develop' into enh/sensors-impl
b4fec6f
@MateusStano
DEV: solve merge issues
de99d86
@MateusStano @Gui-FernandesBR
ENH: Adds GNSS Receiver sensor (#636)
523a819 
* ENH: class GNSS

* ENH: gnss prints

* ENH: add params to measure call

* ENH: export data

* ENH: pass env in .measure

* DOC: gnss attribute docs

* MNT: units in prints

* MNT: fix merge errors

* TST: add gnss tests

* TST: fix time nodes tests

* DEV: add gnss to sensors testing notebook

* DEV: fix merge errors

* MNT: lint and isort

* MNT: black notebooks

* TST: fix test by inversion of rotation

* TST: lower rel tolerances and delete duplicated tests

* MNT: minor fixes

* ENH: export sensor data by sensor name

* MNT: use inverted_haversine in GNSS

* BUG: bearing unit in inverted_haversine

* MNT: pylint

* TST: add test for export with sensor name

* MNT: rename `GNSS` class to `GnssReceiver`

* MNT: fix lint

* MNT: rename gnss file

---------

Co-authored-by: Gui-FernandesBR <[email protected]>
@Gui-FernandesBR
Merge branch 'develop' into enh/sensors-impl
7d873d2
@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Controllers Controlling rocket flight methods labels Sep 8, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Sep 8, 2024
@Gui-FernandesBR Gui-FernandesBR self-assigned this Sep 8, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.44554% with 23 lines in your changes missing coverage. Please review.

Project coverage is 75.42%. Comparing base (2685eba) to head (3c759f7).
Report is 134 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/sensors/sensor.py 93.46% 10 Missing ⚠️
rocketpy/simulation/flight.py 90.62% 6 Missing ⚠️
rocketpy/control/controller.py 75.00% 3 Missing ⚠️
rocketpy/mathutils/vector_matrix.py 90.90% 2 Missing ⚠️
rocketpy/plots/rocket_plots.py 95.83% 1 Missing ⚠️
rocketpy/rocket/components.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #683      +/-   ##
===========================================
+ Coverage    74.46%   75.42%   +0.95%     
===========================================
  Files           89       96       +7     
  Lines        10368    10841     +473     
===========================================
+ Hits          7721     8177     +456     
- Misses        2647     2664      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR marked this pull request as ready for review September 11, 2024 22:10
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner September 11, 2024 22:10
@Gui-FernandesBR Gui-FernandesBR merged commit 3f2a2c5 into develop Sep 12, 2024
5 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/sensors-impl branch September 12, 2024 02:20
@Gui-FernandesBR Gui-FernandesBR linked an issue Sep 12, 2024 that may be closed by this pull request
Sensors #273
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gui-FernandesBR Gui-FernandesBR

Labels
Controllers Controlling rocket flight methods Enhancement New feature or request, including adjustments in current codes
Projects
LibDev Roadmap
Status: Closed
Milestone
Release v1.X.0
Development

Successfully merging this pull request may close these issues.

Sensors
3 participants
@Gui-FernandesBR @MateusStano @lint-action